RESOLVED FIXED88447
Teach git about localizable *.strings files 
https://bugs.webkit.org/show_bug.cgi?id=88447
Summary Teach git about localizable *.strings files
David Kilzer (:ddkilzer)
Reported 2012-06-06 13:12:58 PDT
Teach git about localizable *.strings files
Attachments
Patch v1 (1.20 KB, patch)
2012-06-06 13:13 PDT, David Kilzer (:ddkilzer) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2012-06-06 13:13:58 PDT
Created attachment 146094 [details] Patch v1
WebKit Review Bot
Comment 2 2012-06-06 13:15:32 PDT
Attachment 146094 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'.gitattributes', u'ChangeLog']" exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Roben (:aroben)
Comment 3 2012-06-06 14:03:42 PDT
Comment on attachment 146094 [details] Patch v1 Love it! Will this have any effect (good or bad) for generating patches containing changes to these files?
David Kilzer (:ddkilzer)
Comment 4 2012-06-06 14:16:11 PDT
(In reply to comment #3) > (From update of attachment 146094 [details]) > Love it! > > Will this have any effect (good or bad) for generating patches containing changes to these files? It will have the effect of creating a real diff for *.strings files, but developers will have to run the git-config command in order to get the nicer diffs (as was necessary with the ObjC changes). Thanks Adam!
David Kilzer (:ddkilzer)
Comment 5 2012-06-06 14:20:13 PDT
Committed r119619: <http://trac.webkit.org/changeset/119619>
Adam Roben (:aroben)
Comment 6 2012-06-06 14:26:19 PDT
(In reply to comment #4) > It will have the effect of creating a real diff for *.strings files But will someone else be able to apply that diff to their own tree?
Note You need to log in before you can comment on or make changes to this bug.