WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
253298
Fix control flow with multiple exits on single-pass BBQ JIT
https://bugs.webkit.org/show_bug.cgi?id=253298
Summary
Fix control flow with multiple exits on single-pass BBQ JIT
David Degazio
Reported
2023-03-02 23:06:30 PST
rdar://106182518
Currently, in control flow instructions with multiple exits (namely br_if and br_table), we assume that the calling convention for each target’s block arguments will be the same. This is not the case universally though: - When targeting the top level block, the results are allocated according to the WASM calling convention, not the block calling convention. - If we run out of registers to use for the block calling convention, we pass arguments through WASM canonical stack slots. But the stack height of these may vary between target blocks, even if they have the same signature. To fix this, we need to modify the ControlData methods currently used to manage control flow blocks, to permit setting up for multiple distinct exit branches per block.
Attachments
Add attachment
proposed patch, testcase, etc.
David Degazio
Comment 1
2023-03-02 23:19:51 PST
Pull request:
https://github.com/WebKit/WebKit/pull/10988
EWS
Comment 2
2023-03-03 01:03:36 PST
Committed
261122@main
(bc648d25c5aa): <
https://commits.webkit.org/261122@main
> Reviewed commits have been landed. Closing PR #10988 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug