RESOLVED FIXED252590
Fix entry tier-up SIMD check in BBQ baseline JIT 
https://bugs.webkit.org/show_bug.cgi?id=252590
Summary Fix entry tier-up SIMD check in BBQ baseline JIT
David Degazio
Reported 2023-02-20 11:54:29 PST
rdar://105689397 The OMG entry tier-up path clobbers GPRInfo::argumentGPR0 and GPRInfo::argumentGPR1, but while we will track argument locals as live currently, we don't actively spill to preserve them across the call in the new BBQ baseline JIT, only at the end of the current basic block. We also don't pass whether the current function is a SIMD function to the tier-up thunk generator.
Attachments
Add attachment proposed patch, testcase, etc.
David Degazio
Comment 1 2023-02-20 12:32:07 PST
Looks like Yusuke beat me to the punch on the clobbers...I'll adapt this bug to track specifically the SIMD parameter.
David Degazio
Comment 2 2023-02-20 12:33:09 PST
(fixing the argument register clobbering is tracked in https://bugs.webkit.org/show_bug.cgi?id=252591)
David Degazio
Comment 3 2023-02-20 12:40:12 PST
Pull request: https://github.com/WebKit/WebKit/pull/10383
EWS
Comment 4 2023-02-20 13:17:06 PST
Committed 260562@main (f6adb7641317): <https://commits.webkit.org/260562@main> Reviewed commits have been landed. Closing PR #10383 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.