RESOLVED FIXED137296
Web Inspector: Replace PDF icon with SVG version 
https://bugs.webkit.org/show_bug.cgi?id=137296
Summary Web Inspector: Replace PDF icon with SVG version
Andres Gomez Garcia
Reported 2014-10-01 02:57:21 PDT
The WebInspector still has the icon: Source/WebInspectorUI/UserInterface/Images/NavigationItemProbes.pdf used at: Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.js: WebInspector.DetailsSidebarPanel.call(this, "probe", WebInspector.UIString("Probes"), WebInspector.UIString("Probes"), "Images/NavigationItemProbes.pdf", "6"); PDF icons are not a kind format for other ports like the GTK one so it would be nice to provide a SVG replacement.
Attachments
Partial patch with the free SVG icon for the GTK port (1.18 KB, patch)
2014-10-01 03:05 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Updated: Partial patch with the free SVG icon for the GTK port (4.11 KB, patch)
2014-10-06 06:49 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Patch (213.73 KB, patch)
2014-11-13 11:17 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Screenshot (12.75 KB, image/png)
2014-11-13 11:18 PST, Timothy Hatcher 		no flags
Details
Patch (213.68 KB, patch)
2014-11-13 11:22 PST, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-01 02:57:36 PDT
<rdar://problem/18512186>
Andres Gomez Garcia
Comment 2 2014-10-01 03:05:02 PDT
Created attachment 239018 [details] Partial patch with the free SVG icon for the GTK port
Timothy Hatcher
Comment 3 2014-10-01 09:22:36 PDT
Ah, yes. I have been meaning to convert this PDF to SVG. It slipped in after our initial conversion. Your patch does not have the SVG.
Andres Gomez Garcia
Comment 4 2014-10-06 06:49:37 PDT
Created attachment 239335 [details] Updated: Partial patch with the free SVG icon for the GTK port
Andres Gomez Garcia
Comment 5 2014-10-06 06:50:34 PDT
(In reply to comment #3) > Ah, yes. I have been meaning to convert this PDF to SVG. It slipped in after our initial conversion. > > Your patch does not have the SVG. !!!! Clearly I have to sleep more hours. Thanks for the heads up :)
Timothy Hatcher
Comment 6 2014-11-13 11:17:36 PST
Created attachment 241493 [details] Patch
Timothy Hatcher
Comment 7 2014-11-13 11:18:42 PST
Created attachment 241494 [details] Screenshot
Joseph Pecoraro
Comment 8 2014-11-13 11:20:22 PST
Comment on attachment 241493 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=241493&action=review r=me > Source/WebInspectorUI/UserInterface/Images/NavigationItemProbes.svg:4 > + <!-- <path d="M 2 11 L 2 4 L 11 4 L 15 7.5 L 11 11 L 2 11 Z"></path> --> Why the comment?
Timothy Hatcher
Comment 9 2014-11-13 11:22:53 PST
Created attachment 241495 [details] Patch
Timothy Hatcher
Comment 10 2014-11-13 11:37:02 PST
https://trac.webkit.org/r176080
WebKit Commit Bot
Comment 11 2014-11-13 11:57:03 PST
Comment on attachment 239335 [details] Updated: Partial patch with the free SVG icon for the GTK port Clearing flags on attachment: 239335 Committed r176081: <http://trac.webkit.org/changeset/176081>
WebKit Commit Bot
Comment 12 2014-11-13 11:57:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.