Bug 281892
| Summary: | PAL::TextCodec::getUnencodableReplacement() should return std::span | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=281917 https://bugs.webkit.org/show_bug.cgi?id=281919 |
||
| Bug Depends on: | |||
| Bug Blocks: | 287119 | ||
David Kilzer (:ddkilzer)
PAL::TextCodec::getUnencodableReplacement() should return std::span.
Currently it returns an `int` length, but two out of three uses change that into a `std::span` anyway, and the third passes `data()` and `size_bytes()` into another function as separate parameters.
Found by std::span static analysis checker under development.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/138372354>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/35562
EWS
Committed 285580@main (cccc626b7825): <https://commits.webkit.org/285580@main>
Reviewed commits have been landed. Closing PR #35562 and removing active labels.