Bug 252590
| Summary: | Fix entry tier-up SIMD check in BBQ baseline JIT | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Degazio <d_degazio> |
| Component: | WebAssembly | Assignee: | David Degazio <d_degazio> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 252209 | ||
David Degazio
rdar://105689397
The OMG entry tier-up path clobbers GPRInfo::argumentGPR0 and GPRInfo::argumentGPR1, but while we will track argument locals as live currently, we don't actively spill to preserve them across the call in the new BBQ baseline JIT, only at the end of the current basic block. We also don't pass whether the current function is a SIMD function to the tier-up thunk generator.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Degazio
Looks like Yusuke beat me to the punch on the clobbers...I'll adapt this bug to track specifically the SIMD parameter.
David Degazio
(fixing the argument register clobbering is tracked in https://bugs.webkit.org/show_bug.cgi?id=252591)
David Degazio
Pull request: https://github.com/WebKit/WebKit/pull/10383
EWS
Committed 260562@main (f6adb7641317): <https://commits.webkit.org/260562@main>
Reviewed commits have been landed. Closing PR #10383 and removing active labels.