Bug 137248

Summary: Web Inspector: [GTK] Missing icons and enhancing the proportion and visibility of some icons
Product: WebKit Reporter: Andres Gomez Garcia <agomez>
Component: WebKitGTKAssignee: Andres Gomez Garcia <agomez>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, cgarcia, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Updated patch
none
WebInspector icons before the patch
none
WebInspector icons after the patch none

Andres Gomez Garcia
Reported 2014-09-30 02:59:38 PDT
After fixing bug 136632, there are still some icons missing. In addition, some of the new ones are to light to be understood, like many of the DOM elements. Finally, the proportion of some icons, specially the ones in the navigator bar, is not correct. Some are smaller/bigger than others, unlike in the Apple version. This could be enhanced.
Attachments
Patch (1.11 MB, patch)
2014-09-30 03:28 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
Updated patch (1.10 MB, patch)
2014-10-01 02:46 PDT, Andres Gomez Garcia 		no flags
DetailsFormatted DiffDiff
WebInspector icons before the patch (301.32 KB, image/png)
2014-10-01 02:47 PDT, Andres Gomez Garcia 		no flags
Details
WebInspector icons after the patch (260.23 KB, image/png)
2014-10-01 02:47 PDT, Andres Gomez Garcia 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andres Gomez Garcia
Comment 1 2014-09-30 03:28:21 PDT
Created attachment 238920 [details] Patch
Andres Gomez Garcia
Comment 2 2014-10-01 02:46:33 PDT
Created attachment 239013 [details] Updated patch Removed the PDF icon. I will open a new bug for replacing it with a SVG version.
Andres Gomez Garcia
Comment 3 2014-10-01 02:47:10 PDT
Created attachment 239014 [details] WebInspector icons before the patch
Andres Gomez Garcia
Comment 4 2014-10-01 02:47:35 PDT
Created attachment 239015 [details] WebInspector icons after the patch
Andres Gomez Garcia
Comment 5 2014-10-01 03:05:57 PDT
Opened bug 137296 for the remaining PDF icon.
Carlos Garcia Campos
Comment 6 2014-10-02 03:19:54 PDT
Comment on attachment 239013 [details] Updated patch This requires a clean build in the bots
WebKit Commit Bot
Comment 7 2014-10-02 03:57:36 PDT
Comment on attachment 239013 [details] Updated patch Clearing flags on attachment: 239013 Committed r174207: <http://trac.webkit.org/changeset/174207>
WebKit Commit Bot
Comment 8 2014-10-02 03:57:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.