Bug 96190

Summary: Pass full target idl file path to CodeGenerator as a constructor argument.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: Tools / TestsAssignee: Kangil Han <kangil.han>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, haraken, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 96181    
Attachments:
Description Flags
patch none

Kangil Han
Reported 2012-09-08 22:54:18 PDT
It seems passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files.
Attachments
patch (2.77 KB, patch)
2012-09-09 00:31 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-09-09 00:31:59 PDT
Created attachment 162983 [details] patch
Kentaro Hara
Comment 2 2012-09-09 00:35:20 PDT
Comment on attachment 162983 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=162983&action=review > Source/WebCore/ChangeLog:8 > + Passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files. What use case are you assuming?
Kangil Han
Comment 3 2012-09-09 00:41:04 PDT
(In reply to comment #2) > > What use case are you assuming? At this stage, One use case that fills out derived sources with original copyrights. Please refer to BUG 96181. :-)
Kentaro Hara
Comment 4 2012-09-09 00:44:29 PDT
Comment on attachment 162983 [details] patch OK
Kangil Han
Comment 5 2012-09-09 00:45:40 PDT
(In reply to comment #4) > (From update of attachment 162983 [details]) > OK Thx!!
WebKit Review Bot
Comment 6 2012-09-09 19:08:11 PDT
Comment on attachment 162983 [details] patch Clearing flags on attachment: 162983 Committed r128010: <http://trac.webkit.org/changeset/128010>
WebKit Review Bot
Comment 7 2012-09-09 19:08:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.