Bug 93828

Summary: [EFL][WK2][Minibrowser] Support html link of blank target attribute.
Product: WebKit Reporter: Kangil Han <kangil.han>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: cdumez, d-r, jinwoo7.song, lucas.de.marchi, rakuco, ryuan.choi, tmpsantos, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
patch
none
patch ryuan.choi: commit-queue-

Kangil Han
Reported 2012-08-13 05:29:05 PDT
Supporting html link of blank target attribute would be needed for verifying basic webkit behavior in minibrowser.
Attachments
patch (2.52 KB, patch)
2012-08-13 05:32 PDT, Kangil Han 		no flags
DetailsFormatted DiffDiff
patch (2.58 KB, patch)
2012-08-13 06:34 PDT, Kangil Han 		ryuan.choi: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kangil Han
Comment 1 2012-08-13 05:32:20 PDT
Created attachment 157972 [details] patch
WebKit Review Bot
Comment 2 2012-08-13 05:35:20 PDT
Attachment 157972 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/efl/..." exit_code: 1 Tools/MiniBrowser/efl/main.c:184: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Tools/MiniBrowser/efl/main.c:184: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Tools/MiniBrowser/efl/main.c:195: Missing space after , [whitespace/comma] [3] Tools/MiniBrowser/efl/main.c:209: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kangil Han
Comment 3 2012-08-13 06:34:09 PDT
Created attachment 157981 [details] patch
Kangil Han
Comment 4 2012-08-13 08:38:56 PDT
formal/informal review please!
Raphael Kubo da Costa (:rakuco)
Comment 5 2012-08-13 18:06:31 PDT
Comment on attachment 157981 [details] patch Erm, needing to fork() just launch a new window does not smell very well. I haven't been watching the development of the WK2 port very closely, though. Are you sure there isn't a saner way to do this?
Kangil Han
Comment 6 2012-08-13 18:13:31 PDT
(In reply to comment #5) > (From update of attachment 157981 [details]) > Erm, needing to fork() just launch a new window does not smell very well. I haven't been watching the development of the WK2 port very closely, though. Are you sure there isn't a saner way to do this? Sorry, I don't have an idea at a moment. :-( I will ask more formal/informal reviews. ;-)
Kangil Han
Comment 7 2012-08-13 18:19:20 PDT
ryuan: informal review please?
Ryuan Choi
Comment 8 2012-08-13 18:24:19 PDT
Comment on attachment 157981 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=157981&action=review > Tools/MiniBrowser/efl/main.c:203 > + pid = fork(); > + if (!pid) // child process > + execl(cmd, cmd, url, (char *)NULL); > + else if (pid < 0) // failed to fork > + fprintf(stderr, "Failed to fork\n"); You don't need to fork process. Instead, create new evas and ewk_view. > Tools/MiniBrowser/efl/main.c:253 > + evas_object_smart_callback_add(app->browser, "policy,decision,new,window", on_new_window, app); If I am right, policy,decision,new,window is for creating window. You can call create,window
Ryuan Choi
Comment 9 2012-08-13 18:25:35 PDT
(In reply to comment #8) > (From update of attachment 157981 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=157981&action=review > > > Tools/MiniBrowser/efl/main.c:203 > > + pid = fork(); > > + if (!pid) // child process > > + execl(cmd, cmd, url, (char *)NULL); > > + else if (pid < 0) // failed to fork > > + fprintf(stderr, "Failed to fork\n"); > > You don't need to fork process. > Instead, create new evas and ewk_view. > > > Tools/MiniBrowser/efl/main.c:253 > > + evas_object_smart_callback_add(app->browser, "policy,decision,new,window", on_new_window, app); > > If I am right, policy,decision,new,window is for creating window. "is not for" > > You can call create,window
Jinwoo Song
Comment 10 2012-10-03 10:15:52 PDT
Kangil, can I take over this bug?
Kangil Han
Comment 11 2012-10-03 23:11:53 PDT
(In reply to comment #10) > Kangil, can I take over this bug? Sure!
Jinwoo Song
Comment 12 2012-10-11 17:42:31 PDT
This bug is no more valid as the following patch addressed this issue. http://trac.webkit.org/changeset/130660 *** This bug has been marked as a duplicate of bug 98667 ***
Note You need to log in before you can comment on or make changes to this bug.