Bug 92784

Summary: nrwt: clean up TestInputs in preparation for cleaning up sharding
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 92781    
Bug Blocks: 89267, 92785    
Attachments:
Description Flags
Patch rniwa: review+

Dirk Pranke
Reported 2012-07-31 12:30:29 PDT
nrwt: clean up TestInputs in preparation for cleaning up sharding
Attachments
Patch (21.21 KB, patch)
2012-07-31 12:33 PDT, Dirk Pranke 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-07-31 12:33:22 PDT
Created attachment 155605 [details] Patch
Ryosuke Niwa
Comment 2 2012-07-31 12:52:47 PDT
Comment on attachment 155605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=155605&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_input.py:40 > + self.timeout = timeout # in msecs; should rename this for consistency Nit: ms is a SI unit whereas msecs isn't.
Dirk Pranke
Comment 3 2012-07-31 13:02:50 PDT
(In reply to comment #2) > (From update of attachment 155605 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=155605&action=review > > > Tools/Scripts/webkitpy/layout_tests/models/test_input.py:40 > > + self.timeout = timeout # in msecs; should rename this for consistency > > Nit: ms is a SI unit whereas msecs isn't. good point.
Dirk Pranke
Comment 4 2012-07-31 13:49:06 PDT
Committed r124246: <http://trac.webkit.org/changeset/124246>
Note You need to log in before you can comment on or make changes to this bug.