Bug 92695

Summary: Fix potential compile error on LocalFileSystem::deleteFileSystem
Product: WebKit Reporter: Taiju Tsuiki <tzik>
Component: WebCore Misc.Assignee: Taiju Tsuiki <tzik>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Taiju Tsuiki
Reported 2012-07-30 17:27:22 PDT
The callback type in LocalFileSystem::deleteFileSystem arguments should AsyncFileSystemCallbacks, instead of ErrorCallback. # Sorry, I contaminated with it a few weeks ago.
Attachments
Patch (1.92 KB, patch)
2012-07-30 17:29 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Patch (2.22 KB, patch)
2012-07-31 10:22 PDT, Taiju Tsuiki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Taiju Tsuiki
Comment 1 2012-07-30 17:29:27 PDT
Created attachment 155407 [details] Patch
Adam Barth
Comment 2 2012-07-31 09:12:44 PDT
Comment on attachment 155407 [details] Patch Ok. Can you explain the change a bit more in the ChangeLog? For example, which builds are broken and why the chromium build works.
Taiju Tsuiki
Comment 3 2012-07-31 10:22:28 PDT
Created attachment 155581 [details] Patch
Taiju Tsuiki
Comment 4 2012-07-31 10:25:09 PDT
(In reply to comment #2) > (From update of attachment 155407 [details]) > Ok. Can you explain the change a bit more in the ChangeLog? For example, which builds are broken and why the chromium build works. Sure, I updated the ChangeLog.
Adam Barth
Comment 5 2012-07-31 11:52:23 PDT
Comment on attachment 155581 [details] Patch Thanks.
WebKit Review Bot
Comment 6 2012-07-31 12:20:47 PDT
Comment on attachment 155581 [details] Patch Clearing flags on attachment: 155581 Committed r124238: <http://trac.webkit.org/changeset/124238>
WebKit Review Bot
Comment 7 2012-07-31 12:20:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.