Bug 90825

Summary: [chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Dana Jansens <danakj>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, piman, shawnsingh, webkit.review.bot, wjmaclean, zlieber
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 90573    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Dana Jansens
Reported 2012-07-09 14:58:13 PDT
[chromium] Remove HashMap workaround for layers with id=0 in CCDamageTracker
Attachments
Patch (2.04 KB, patch)
2012-07-09 14:59 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch (2.83 KB, patch)
2012-07-09 15:03 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.88 KB, patch)
2012-07-09 15:46 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2012-07-09 14:59:24 PDT
Created attachment 151326 [details] Patch
Dana Jansens
Comment 2 2012-07-09 15:00:05 PDT
(tests will fail until bug #90573 lands)
Adrienne Walker
Comment 3 2012-07-09 15:01:24 PDT
Can you also add an assert to CCDamageTracker::saveRectForNextFrame that layerId > 0?
Dana Jansens
Comment 4 2012-07-09 15:03:23 PDT
yuppers.
Dana Jansens
Comment 5 2012-07-09 15:03:37 PDT
Created attachment 151327 [details] Patch
Adrienne Walker
Comment 6 2012-07-09 15:04:18 PDT
Comment on attachment 151327 [details] Patch R=me. Thanks. :)
WebKit Review Bot
Comment 7 2012-07-09 15:43:54 PDT
Comment on attachment 151327 [details] Patch Rejecting attachment 151327 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: hics/chromium/cc/CCHeadsUpDisplay.o Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp: In member function 'void WebCore::CCDamageTracker::saveRectForNextFrame(int, const WebCore::FloatRect&)': Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.cpp:189: error: 'layerId' was not declared in this scope make: *** [out/Debug/obj.target/webcore_chromium_compositor/Source/WebCore/platform/graphics/chromium/cc/CCDamageTracker.o] Error 1 make: *** Waiting for unfinished jobs.... Full output: http://queues.webkit.org/results/13172245
Dana Jansens
Comment 8 2012-07-09 15:46:11 PDT
Created attachment 151334 [details] Patch for landing
WebKit Review Bot
Comment 9 2012-07-09 17:17:40 PDT
Comment on attachment 151334 [details] Patch for landing Clearing flags on attachment: 151334 Committed r122170: <http://trac.webkit.org/changeset/122170>
WebKit Review Bot
Comment 10 2012-07-09 17:17:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.