Bug 89267

Summary: nrwt: restructure manager code
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, tony
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 89725, 92423, 92527, 92693, 92694, 92701, 92702, 92781, 92784, 92785, 92804, 92805, 92806    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
roll-up patch based of of r121304 + mwb_cleanup + tw_cleanup none

Dirk Pranke
Reported 2012-06-15 19:34:27 PDT
nrwt: restructure manager code
Attachments
Patch (126.17 KB, patch)
2012-06-15 19:34 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
roll-up patch based of of r121304 + mwb_cleanup + tw_cleanup (127.82 KB, patch)
2012-06-26 19:49 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-06-15 19:34:55 PDT
Created attachment 147940 [details] Patch
Dirk Pranke
Comment 2 2012-06-26 19:49:01 PDT
Created attachment 149668 [details] roll-up patch based of of r121304 + mwb_cleanup + tw_cleanup Definitely not for review ... this patch needs a little more work plus all the tests revamped, then broken into more reviewable chunks, of course.
Dirk Pranke
Comment 3 2012-06-26 19:49:42 PDT
I don't think this technically relies on 76022, but it makes my git branching easier to think that it does ...
Dirk Pranke
Comment 4 2012-07-26 19:44:47 PDT
Okay, I've done most of the remaining work for this, so more patches will be showing up shortly ...
Dirk Pranke
Comment 5 2012-07-31 18:56:24 PDT
All patches have been landed (hopefully they'll stick). manager.py is almost a thousand lines smaller compared to the version in r122384 (the last version before I started moving stuff): 1582 lines -> 619 :).
Note You need to log in before you can comment on or make changes to this bug.