Bug 85460

Summary: Add PNG image pngsuite test
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: Tools / TestsAssignee: noel gordon <noel.gordon>
Status: RESOLVED LATER    
Severity: Normal CC: abarth, dglazkov, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ec2-cr-linux-03 none

noel gordon
Reported 2012-05-02 23:31:36 PDT
Add PNG image pngsuite tests from http://www.schaik.com/pngsuite
Attachments
Patch (271.51 KB, patch)
2012-05-02 23:53 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch (272.76 KB, patch)
2012-05-03 00:51 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cr-linux-03 (6.14 MB, application/zip)
2012-05-03 01:37 PDT, WebKit Review Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-05-02 23:53:36 PDT
Created attachment 139965 [details] Patch
WebKit Review Bot
Comment 2 2012-05-02 23:59:02 PDT
Attachment 139965 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 844, in process min_confidence) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch min_confidence) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker checker = PNGChecker(file_path, handle_style_error) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__ self._fs = host.filesystem AttributeError: 'NoneType' object has no attribute 'filesystem' If any of these errors are false positives, please file a bug against check-webkit-style.
noel gordon
Comment 3 2012-05-03 00:50:40 PDT
Make the expectations = MISSING IMAGE
noel gordon
Comment 4 2012-05-03 00:51:19 PDT
Created attachment 139969 [details] Patch
WebKit Review Bot
Comment 5 2012-05-03 00:57:47 PDT
Attachment 139969 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/filereader.py", line 130, in process_file self._processor.process(lines, file_path, **kwargs) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 844, in process min_confidence) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 619, in dispatch min_confidence) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checker.py", line 593, in _create_checker checker = PNGChecker(file_path, handle_style_error) File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/style/checkers/png.py", line 43, in __init__ self._fs = host.filesystem AttributeError: 'NoneType' object has no attribute 'filesystem' If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 6 2012-05-03 01:37:20 PDT
Comment on attachment 139969 [details] Patch Attachment 139969 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12606124 New failing tests: fast/images/png-suite/test.html
WebKit Review Bot
Comment 7 2012-05-03 01:37:26 PDT
Created attachment 139971 [details] Archive of layout-test-results from ec2-cr-linux-03 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-03 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
noel gordon
Comment 8 2012-05-03 02:04:22 PDT
(In reply to comment #3) > Make the expectations = MISSING IMAGE Nah, = IMAGE was fine, going with the first patch then ...
noel gordon
Comment 9 2012-05-03 19:01:56 PDT
Closing this bug. Too much spew due to the broken style bot.
Adam Barth
Comment 10 2012-05-03 19:26:57 PDT
(In reply to comment #9) > Closing this bug. Too much spew due to the broken style bot. Sorry about that. :(
noel gordon
Comment 11 2012-05-03 21:21:07 PDT
No problem, moved it all to bug 85567 (All this came from https://bugs.webkit.org/show_bug.cgi?id=85276#c4, and welcome back Adam btw).
Eric Seidel (no email)
Comment 12 2012-05-21 15:19:43 PDT
Comment on attachment 139965 [details] Patch Cleared review? from obsolete attachment 139965 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.