Bug 85276

Summary: PNGImageDecoder: Handle interlace buffer allocation failure
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

noel gordon
Reported 2012-05-01 05:49:09 PDT
PNGImageDEcoder: Handle interlace buffer allocation failure
Attachments
Patch (3.19 KB, patch)
2012-05-01 05:50 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-05-01 05:50:15 PDT
Created attachment 139617 [details] Patch
Eric Seidel (no email)
Comment 2 2012-05-01 19:12:39 PDT
Comment on attachment 139617 [details] Patch Do we have an image we can test this with? It seems if we keep maintaining a PNG decoder (which we really *don't* want to do as a project), we will need to come up with a testing harness and a corpus of a bunch of broken png files. :(
noel gordon
Comment 3 2012-05-01 19:24:15 PDT
No, no test image sorry. Agree we need to come up with a better test suite.
noel gordon
Comment 4 2012-05-01 19:28:29 PDT
So it's impractical to test this with our current technology, but the plan is to move towards using pngsuite for testing our decoder, which should catch issues like this one. http://www.schaik.com/pngsuite
Eric Seidel (no email)
Comment 5 2012-05-01 19:29:21 PDT
Comment on attachment 139617 [details] Patch OK.
WebKit Review Bot
Comment 6 2012-05-01 20:19:48 PDT
Comment on attachment 139617 [details] Patch Clearing flags on attachment: 139617 Committed r115784: <http://trac.webkit.org/changeset/115784>
WebKit Review Bot
Comment 7 2012-05-01 20:19:59 PDT
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 8 2012-05-02 23:55:43 PDT
(In reply to comment #4) > So it's impractical to test this with our current technology, but the plan is to move towards using pngsuite for testing our decoder, which should catch issues like this one. http://www.schaik.com/pngsuite "may help catch issues like this one", filed bug 85460
noel gordon
Comment 9 2012-05-03 19:25:51 PDT
Closed bug 85460 (too much broken style bot noise). Filed bug 85567.
Note You need to log in before you can comment on or make changes to this bug.