Bug 79723

Summary: [chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, nduca, shawnsingh, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67499, 79428    
Attachments:
Description Flags
Patch enne: review+

James Robinson
Reported 2012-02-27 17:31:51 PST
[chromium] Rename LayerChromium::name to debugName to be more consistent with other debug properties, make threadsafe
Attachments
Patch (10.50 KB, patch)
2012-02-27 17:32 PST, James Robinson 		enne: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-02-27 17:32:20 PST
Created attachment 129147 [details] Patch
Adrienne Walker
Comment 2 2012-03-01 10:03:41 PST
Comment on attachment 129147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=129147&action=review Yay, thread safety. > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:-492 > - EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(0, testLayer->setName("Test Layer")); nit: Can you move this line to the section that makes sure it does call needsCommit rather than just removing it?
James Robinson
Comment 3 2012-03-01 16:48:09 PST
Committed r109466: <http://trac.webkit.org/changeset/109466>
James Robinson
Comment 4 2012-03-01 16:48:58 PST
(In reply to comment #2) > (From update of attachment 129147 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=129147&action=review > > Yay, thread safety. > > > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:-492 > > - EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(0, testLayer->setName("Test Layer")); > > nit: Can you move this line to the section that makes sure it does call needsCommit rather than just removing it? Done!
Note You need to log in before you can comment on or make changes to this bug.