Bug 72778

Summary: [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, schenney, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71225    
Attachments:
Description Flags
Patch kbr: review+, webkit.review.bot: commit-queue-

James Robinson
Reported 2011-11-18 17:34:31 PST
[chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
Attachments
Patch (1.68 KB, patch)
2011-11-18 17:35 PST, James Robinson 		kbr: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-11-18 17:35:55 PST
Created attachment 115917 [details] Patch
James Robinson
Comment 2 2011-11-18 17:36:37 PST
The tests in https://bugs.webkit.org/show_bug.cgi?id=71225 barf without this
Kenneth Russell
Comment 3 2011-11-18 18:18:43 PST
Comment on attachment 115917 [details] Patch Looks fine. r=me
James Robinson
Comment 4 2011-11-18 18:26:03 PST
Committed r100835: <http://trac.webkit.org/changeset/100835>
James Robinson
Comment 5 2011-11-18 18:40:42 PST
Reverted r100835 for reason: Broke some page scale tests Committed r100837: <http://trac.webkit.org/changeset/100837>
WebKit Review Bot
Comment 6 2011-11-18 20:36:53 PST
Comment on attachment 115917 [details] Patch Attachment 115917 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10523007 New failing tests: fast/events/page-scaled-mouse-click-iframe.html css2.1/20110323/abspos-containing-block-initial-004b.htm fast/events/platform-wheelevent-paging-x-in-scrolling-page.html fast/repaint/background-scaling.html fast/replaced/width100percent-textarea.html fast/events/reveal-link-when-focused.html http/tests/inspector/network-preflight-options.html fast/events/platform-wheelevent-paging-y-in-scrolling-page.html fast/events/platform-wheelevent-paging-xy-in-scrolling-page.html fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html fast/events/page-scaled-mouse-click.html css2.1/20110323/abspos-containing-block-initial-004d.htm fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html fast/events/pointer-events-2.html
Note You need to log in before you can comment on or make changes to this bug.