Bug 72521

Summary: [chromium] Track property changes for render surfaces
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: cc-bugs, enne, jamesr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67341, 72520    
Attachments:
Description Flags
Patch
none
fixed if-statemets to follow webkit conventions none

Shawn Singh
Reported 2011-11-16 10:26:16 PST
In the process of implementing the CCDamageTracker, https://bugs.webkit.org/show_bug.cgi?id=72520 it became clear that we need to track damage on render surfaces, similar to the way we already track damage for layers. To do this cleanly, it is also appropriate to re-name some of the functions that track property changes for layers as well.
Attachments
Patch (15.90 KB, patch)
2011-11-16 13:12 PST, Shawn Singh 		no flags
DetailsFormatted DiffDiff
fixed if-statemets to follow webkit conventions (15.91 KB, patch)
2011-11-16 13:24 PST, Shawn Singh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2011-11-16 10:45:22 PST
(In reply to comment #0) > In the process of implementing the CCDamageTracker, https://bugs.webkit.org/show_bug.cgi?id=72520 it became clear that we need to track damage on render surfaces, similar to the way we already track damage for layers. > To do this cleanly, it is also appropriate to re-name some of the functions that track property changes for layers as well. Oops, I should say "track property changes" rather than "track damage" for this patch.
Shawn Singh
Comment 2 2011-11-16 13:12:08 PST
Created attachment 115430 [details] Patch
Shawn Singh
Comment 3 2011-11-16 13:24:15 PST
Created attachment 115433 [details] fixed if-statemets to follow webkit conventions
Adrienne Walker
Comment 4 2011-11-16 15:31:39 PST
Comment on attachment 115433 [details] fixed if-statemets to follow webkit conventions This unofficially looks good to me.
James Robinson
Comment 5 2011-11-16 15:37:29 PST
Comment on attachment 115433 [details] fixed if-statemets to follow webkit conventions R=me
WebKit Review Bot
Comment 6 2011-11-16 17:00:03 PST
Comment on attachment 115433 [details] fixed if-statemets to follow webkit conventions Clearing flags on attachment: 115433 Committed r100530: <http://trac.webkit.org/changeset/100530>
WebKit Review Bot
Comment 7 2011-11-16 17:00:08 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.