Bug 68890

Summary:

[v8] Code calling the typed array optimization script is fragile, depends on typed array hierarchy.

Product:

WebKit

Reporter:

Ulan Degenbaev <ulan>

Component:

WebGL

Assignee:

Ulan Degenbaev <ulan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, kbr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

68237

Bug Blocks:

75532, 76040, 104099

Attachments:

Description	Flags
Install the flag, which indicates whether or not the optimization script was executed, on the global object.	none

Ulan Degenbaev

Reported 2011-09-27 05:04:14 PDT

See https://bugs.webkit.org/show_bug.cgi?id=68237#c2 .

Attachments
Install the flag, which indicates whether or not the optimization script was executed, on the global object. (2.68 KB, patch) 2011-09-27 09:52 PDT, Ulan Degenbaev	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ulan Degenbaev

Comment 1 2011-09-27 09:52:30 PDT

Created attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object.

Kenneth Russell

Comment 2 2011-09-27 10:47:32 PDT

Comment on attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object. Looks good. Thanks for cleaning this up. r=me

WebKit Review Bot

Comment 3 2011-09-27 11:18:06 PDT

Comment on attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object. Clearing flags on attachment: 108860 Committed r96135: <http://trac.webkit.org/changeset/96135>

WebKit Review Bot

Comment 4 2011-09-27 11:18:10 PDT

All reviewed patches have been landed. Closing bug.

Adam Barth

Comment 5 2012-12-04 21:06:42 PST

Comment on attachment 108860 [details] Install the flag, which indicates whether or not the optimization script was executed, on the global object. View in context: https://bugs.webkit.org/attachment.cgi?id=108860&action=review > Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:36 > -const char fastSetFlagName[] = "webgl::FastSetFlag"; > +// The random suffix helps to avoid name collision. > +const char fastSetFlagName[] = "TypedArray::FastSet::8NkZVq"; There's no reason to use goofy names like this. The http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h class helps us avoid naming collisions.

Ulan Degenbaev

Comment 6 2012-12-05 01:23:23 PST

Thanks, Adam! I file a bug https://bugs.webkit.org/show_bug.cgi?id=104099 and will upload a fix.

Note You need to log in before you can comment on or make changes to this bug.