Bug 31052

Summary: Web Inspector: Prepare for heap profiles upstreaming
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, commit-queue, pfeldman, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed change
pfeldman: review-
proposed change, comments addressed none

Mikhail Naganov
Reported 2009-11-03 04:55:25 PST
Add new functionality by deleting some code ;) - pass profile type id from InspectorController; - this makes WebInspector.CPUProfile redundant---removed; - support multiple profile types when populating profiles.
Attachments
proposed change (4.54 KB, patch)
2009-11-03 04:57 PST, Mikhail Naganov 		pfeldman: review-
DetailsFormatted DiffDiff
proposed change, comments addressed (4.98 KB, patch)
2009-11-03 06:55 PST, Mikhail Naganov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2009-11-03 04:57:13 PST
Created attachment 42367 [details] proposed change
Pavel Feldman
Comment 2 2009-11-03 06:34:22 PST
Comment on attachment 42367 [details] proposed change > - this.panels.profiles.addProfileHeader(WebInspector.CPUProfileType.TypeId, new WebInspector.CPUProfile(profile)); > + this.panels.profiles.addProfileHeader(profile.typeId, profile); If every profile has typeId from now on, should we pass single argument here?
Mikhail Naganov
Comment 3 2009-11-03 06:55:56 PST
Created attachment 42378 [details] proposed change, comments addressed
WebKit Commit Bot
Comment 4 2009-11-03 09:47:48 PST
Comment on attachment 42378 [details] proposed change, comments addressed Clearing flags on attachment: 42378 Committed r50460: <http://trac.webkit.org/changeset/50460>
WebKit Commit Bot
Comment 5 2009-11-03 09:47:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.