Bug 281919
| Summary: | WebCore::DecodedHTMLEntity::span() should use std::span::first() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebCore Misc. | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=281892 https://bugs.webkit.org/show_bug.cgi?id=281917 |
||
David Kilzer (:ddkilzer)
WebCore::DecodedHTMLEntity::span() should use std::span::first().
This code currently avoids bounds checking of `m_characters` when creating std::span:
```
constexpr std::span<const UChar> span() const { return { m_characters.data(), m_length }; }
```
Found by std::span clang static analysis checker under development.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/138431470>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/35585
EWS
Committed 285583@main (b8b9ecf63b67): <https://commits.webkit.org/285583@main>
Reviewed commits have been landed. Closing PR #35585 and removing active labels.