Bug 260828

Summary:	REGRESSION(267111@main): Safari crash when tapping “allow for one day” Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid parameter not satisfying: [urlToMatch isKindOfClass:NSURL.class]'
Product:	WebKit	Reporter:	Timothy Hatcher <timothy>
Component:	WebKit Extensions	Assignee:	Timothy Hatcher <timothy>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	timothy, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Timothy Hatcher

Reported 2023-08-28 15:52:15 PDT

Last Exception Backtrace: 0 CoreFoundation 0x1a50aadd4 __exceptionPreprocess + 164 (/Library/Caches/com.apple.xbs/Sources/CoreFoundation/CoreFoundation/ObjC.subproj/NSException.m:249) 1 libobjc.A.dylib 0x19d33fc00 objc_exception_throw + 60 (/Library/Caches/com.apple.xbs/Sources/objc4/runtime/objc-exception.mm:356) 2 Foundation 0x1a4616f98 -[NSAssertionHandler handleFailureInMethod:object:file:lineNumber:description:] + 188 (/Library/Caches/com.apple.xbs/Sources/Foundation/Foundation/ObjC.subproj/NSException.m:252) 3 WebKit 0x107f67d6c -[_WKWebExtensionMatchPattern matchesURL:options:] + 244 (/Library/Caches/com.apple.xbs/Sources/64e760e3-5944-4bdc-b070-1e8ed692370c/WebKit-SHA__dc989b3ef737547949c45f39dc996f0850fe862f/Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionMatchPattern.mm:236) 4 SafariCore 0x10fb11188 -[NSSet(SafariCoreExtras) safari_anyObjectPassingTest:] + 168 (/Library/Caches/com.apple.xbs/Sources/8a35c7ba-9882-4520-84c7-ea00c3ca6c6a/Safari-SHA__37a6437928e06c6fdb4b8f3c4a642610d6529975/SafariShared/SafariCore/FoundationExtras/WBSNSSetExtras.m:62) 5 SafariCore 0x10fb11228 -[NSSet(SafariCoreExtras) safari_containsObjectPassingTest:] + 20 (/Library/Caches/com.apple.xbs/Sources/8a35c7ba-9882-4520-84c7-ea00c3ca6c6a/Safari-SHA__37a6437928e06c6fdb4b8f3c4a642610d6529975/SafariShared/SafariCore/FoundationExtras/WBSNSSetExtras.m:71) 6 SafariSharedUI 0x10559c140 __91-[WBSWebExtensionsController _fireOnUpdatedEventForTabsMatchingOriginPatterns:toExtension:]_block_invoke + 140 (/Library/Caches/com.apple.xbs/Sources/8a35c7ba-9882-4520-84c7-ea00c3ca6c6a/Safari-SHA__37a6437928e06c6fdb4b8f3c4a642610d6529975/SafariShared/Extensions/WBSWebExtensionsController.mm:4871) 7 SafariSharedUI 0x10559bfec -[WBSWebExtensionsController _fireOnUpdatedEventForTabsMatchingOriginPatterns:toExtension:] + 288 (/Library/Caches/com.apple.xbs/Sources/8a35c7ba-9882-4520-84c7-ea00c3ca6c6a/Safari-SHA__37a6437928e06c6fdb4b8f3c4a642610d6529975/SafariShared/Extensions/WBSWebExtensionsController.mm:4878) rdar://114581149

Attachments
Add attachment proposed patch, testcase, etc.

Timothy Hatcher

Comment 1 2023-08-28 15:56:08 PDT

Pull request: https://github.com/WebKit/WebKit/pull/17153

EWS

Comment 2 2023-08-28 16:43:18 PDT

Committed 267373@main (4bd7a7653518): <https://commits.webkit.org/267373@main> Reviewed commits have been landed. Closing PR #17153 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.