Bug 242252
| Summary: | GitHub links are broken in Bugzilla patch review | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | jbedard, mitz, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Alexey Proskuryakov
GitHub links in patch review go to URLs like https://github.com/WebKit/WebKit/blob/%7Bfilename%7D#L2570
Steps to reproduce:
1. Open any new patch for review, e.g. https://bugs.webkit.org/attachment.cgi?id=460612&action=review
2. Click on file name, e.g. "Source/WebCore/css/CSSComputedStyleDeclaration.cpp"
Results: GitHub 404 page, the URL is obviously wrong.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/96676738>
Alexey Proskuryakov
*** Bug 244857 has been marked as a duplicate of this bug. ***
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/8263
EWS
Committed 258540@main (cc9e0d6d9154): <https://commits.webkit.org/258540@main>
Reviewed commits have been landed. Closing PR #8263 and removing active labels.