Bug 240843

Created attachment 459694 [details] Patch

Comment on attachment 459694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=459694&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:434 > + if (MacApplication::isAppleMail() || CocoaApplication::isWebkitTestRunner()) { What are we trying to achieve with this check? It's not clear to me if this is security sensitive, but anyone can build a "WebKitTestRunner". Maybe a "Mail" too, depending on how the check is implemented. > LayoutTests/platform/mac/TestExpectations:2305 > +[ Catalina+ ] fast/images/animated-heics-draw.html [ Pass ] > +[ Catalina+ ] fast/images/animated-heics-verify.html [ Pass ] > +[ BigSur+ ] fast/images/heic-as-background-image.html [ Pass ] OS version qualifiers are not needed here, Big Sur is the oldest supported OS version.

Pull request: https://github.com/WebKit/WebKit/pull/979

(In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 459694 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=459694&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:434 > > + if (MacApplication::isAppleMail() || CocoaApplication::isWebkitTestRunner()) { > > What are we trying to achieve with this check? It's not clear to me if this > is security sensitive, but anyone can build a "WebKitTestRunner". Maybe a > "Mail" too, depending on how the check is implemented. > This is what allows the tests to decode the HEIC images. This just checks the bundle identifier, which is the same as the mail check. I don't think this would have any security implications, but I will ask Per Arne to review to be sure.

Committed r294764 (250930@main): <https://commits.webkit.org/250930@main> Reviewed commits have been landed. Closing PR #979 and removing active labels.