Bug 239913

Summary: [CMake] Add a macro to set source file language
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: annulen, ews-watchlist, gyuyoung.kim, keith_miller, mark.lam, msaboff, ryuan.choi, saam, sergio, stephan.szabo, tzagallo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=239873
Attachments:
Description Flags
WIP Patch none

Don Olmstead
Reported 2022-04-29 14:25:27 PDT
After the change in r239873 the Visual Studio build for PlayStation fails due to the unified c file being compiled with -std=c++. Specify the language type to get around this.
Attachments
WIP Patch (10.59 KB, patch)
2022-04-29 15:06 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2022-04-29 15:06:03 PDT
Created attachment 458611 [details] WIP Patch
Stephan Szabo
Comment 2 2022-04-29 15:24:52 PDT
I'm not sure how you will want to handle https://github.com/WebKit/WebKit/blob/main/Source/bmalloc/CMakeLists.txt#L685-L696 with this. It happens after the WEBKIT_FRAMEWORK* in the file, so if I'm reading this right we'll set the standard to a C language standard but then later change the compile language to C++.
Note You need to log in before you can comment on or make changes to this bug.