Bug 229844

Summary: FontFaceSet.check() needs to react to style changes
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=230062
Bug Depends on:    
Bug Blocks: 229850, 229911, 229975    
Attachments:
Description Flags
Patch
none
Patch sam: review+

Myles C. Maxfield
Reported 2021-09-02 18:52:05 PDT
FontFaceSet.check() needs to react to style changes
Attachments
Patch (5.58 KB, patch)
2021-09-02 19:03 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (5.57 KB, patch)
2021-09-02 19:15 PDT, Myles C. Maxfield 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-09-02 19:03:58 PDT
Created attachment 437232 [details] Patch
Myles C. Maxfield
Comment 2 2021-09-02 19:09:56 PDT
Comment on attachment 437232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437232&action=review > LayoutTests/fast/text/FontFaceSet-check-after-style-update.html:24 > +document.fonts.values().next().value.load(); This should be just "fonts.values().next().value.load()".
Myles C. Maxfield
Comment 3 2021-09-02 19:15:36 PDT
Created attachment 437234 [details] Patch
Sam Weinig
Comment 4 2021-09-03 09:46:37 PDT
Comment on attachment 437234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437234&action=review Should we / can we have a font resource that never get's cached (e.g. sets the right headers) to avoid the need to invalidate? > Source/WebCore/css/FontFaceSet.cpp:186 > + auto protect = m_backing; Like the other patch, I would change this to: Ref protect = m_backing; (assuming that compiles).
Myles C. Maxfield
Comment 5 2021-09-03 13:08:14 PDT
Committed r282016 (241321@main): <https://commits.webkit.org/241321@main>
Radar WebKit Bug Importer
Comment 6 2021-09-03 13:09:19 PDT
<rdar://problem/82735822>
Note You need to log in before you can comment on or make changes to this bug.