Bug 224723

Summary: RemoteImageDecoderAVFManager should never re-launch the GPUProcess on destruction
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224556
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-04-17 15:35:42 PDT
RemoteImageDecoderAVFManager should never re-launch the GPUProcess on destruction.
Attachments
Patch (8.59 KB, patch)
2021-04-17 15:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-04-17 15:40:29 PDT
Created attachment 426353 [details] Patch
Darin Adler
Comment 2 2021-04-17 15:44:27 PDT
Comment on attachment 426353 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426353&action=review > Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:82 > + // FIXME: Do we need to do more when m_remoteImageDecoders is not empty to re-create them? You’d think they’d either need to fail or get re-created.
Chris Dumez
Comment 3 2021-04-17 15:46:31 PDT
(In reply to Darin Adler from comment #2) > Comment on attachment 426353 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426353&action=review > > > Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:82 > > + // FIXME: Do we need to do more when m_remoteImageDecoders is not empty to re-create them? > > You’d think they’d either need to fail or get re-created. Yes, we likely need to do something. I will ping the media team about this pre-existing issue.
EWS
Comment 4 2021-04-17 16:22:20 PDT
Committed r276212 (236694@main): <https://commits.webkit.org/236694@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426353 [details].
Peng Liu
Comment 5 2021-04-19 09:41:47 PDT
(In reply to Chris Dumez from comment #3) > (In reply to Darin Adler from comment #2) > > Comment on attachment 426353 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=426353&action=review > > > > > Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp:82 > > > + // FIXME: Do we need to do more when m_remoteImageDecoders is not empty to re-create them? > > > > You’d think they’d either need to fail or get re-created. > > Yes, we likely need to do something. I will ping the media team about this > pre-existing issue. Yes. Filed webkit.org/b/224766 to track that.
Radar WebKit Bug Importer
Comment 6 2021-04-24 15:06:56 PDT
<rdar://problem/77110085>
Note You need to log in before you can comment on or make changes to this bug.