Bug 224449

Summary: Remove support for NPAPI plugins in WebView
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224441
Bug Depends on:    
Bug Blocks: 224441    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2021-04-12 13:30:30 PDT
Remove support for NPAPI plugins in WebView
Attachments
Patch (4.21 KB, patch)
2021-04-12 13:32 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.04 KB, patch)
2021-04-12 14:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (4.17 KB, patch)
2021-04-12 15:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2021-04-27 13:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (5.15 KB, patch)
2021-04-27 15:43 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-04-12 13:32:17 PDT
Created attachment 425782 [details] Patch
Alex Christensen
Comment 2 2021-04-12 14:45:31 PDT
Created attachment 425792 [details] Patch
Chris Dumez
Comment 3 2021-04-12 14:48:51 PDT
Comment on attachment 425792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425792&action=review > Source/WebKitLegacy/mac/WebView/WebPreferences.mm:-903 > - [self _setBoolValue: flag forKey: WebKitPluginsEnabledPreferenceKey]; Same comment as on the other patch. I think this should RELEASE_LOG_FAULT() when flag is YES to make issues more obvious in sysdiagnoses. > Tools/DumpRenderTree/TestOptions.cpp:66 > + { "PluginsEnabled", true }, Why was this moved out of PLATFORM(COCOA)?
Alex Christensen
Comment 4 2021-04-12 14:56:14 PDT
Comment on attachment 425792 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425792&action=review >> Tools/DumpRenderTree/TestOptions.cpp:66 >> + { "PluginsEnabled", true }, > > Why was this moved out of PLATFORM(COCOA)? It was moved out of PLATFORM(WIN) to also apply to PLATFORM(COCOA)
Alex Christensen
Comment 5 2021-04-12 15:00:48 PDT
Created attachment 425797 [details] Patch
EWS
Comment 6 2021-04-13 14:21:03 PDT
Committed r275912 (236476@main): <https://commits.webkit.org/236476@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425797 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-13 14:22:15 PDT
<rdar://problem/76610280>
Alex Christensen
Comment 8 2021-04-27 11:44:33 PDT
This needs to be reverted because it caused rdar://77179042
Alex Christensen
Comment 9 2021-04-27 11:53:06 PDT
http://trac.webkit.org/r276652
Alex Christensen
Comment 10 2021-04-27 13:29:26 PDT
Reopening to attach new patch.
Alex Christensen
Comment 11 2021-04-27 13:29:28 PDT
Created attachment 427187 [details] Patch
Geoffrey Garen
Comment 12 2021-04-27 14:02:13 PDT
Seems like Mac-wk1 needs updated test results
Alex Christensen
Comment 13 2021-04-27 15:43:19 PDT
Created attachment 427206 [details] Patch
Geoffrey Garen
Comment 14 2021-04-28 10:02:03 PDT
Comment on attachment 427206 [details] Patch r=me
EWS
Comment 15 2021-04-28 10:19:41 PDT
Committed r276720 (237124@main): <https://commits.webkit.org/237124@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427206 [details].
Note You need to log in before you can comment on or make changes to this bug.