Bug 222078

Summary:

Experiment with using the theme-color as the scroll area background if provided

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

New Bugs

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, cdumez, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, hi, kangil.han, kondapallykalyan, pdr, simon.fraser, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

224455

Attachments:

Description	Flags
Patch	thorton: review+, ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Devin Rousso

Reported 2021-02-17 15:09:19 PST

`<meta name="theme-color" content="...">` would be used (if provided) instead of the `pageExtendedBackgroundColor`

Attachments
Patch (8.67 KB, patch) 2021-02-17 15:10 PST, Devin Rousso	thorton: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.85 KB, patch) 2021-02-17 15:49 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.85 KB, patch) 2021-02-17 15:52 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.86 KB, patch) 2021-02-17 15:57 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.81 KB, patch) 2021-02-17 16:11 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (8.82 KB, patch) 2021-02-17 16:12 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (8.82 KB, patch) 2021-02-17 16:13 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.82 KB, patch) 2021-02-17 16:24 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.79 KB, patch) 2021-02-17 17:38 PST, Devin Rousso	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (8.83 KB, patch) 2021-02-17 17:59 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2021-02-17 15:09:36 PST

<rdar://problem/74158818>

Devin Rousso

Comment 2 2021-02-17 15:10:21 PST

Created attachment 420730 [details] Patch

Tim Horton

Comment 3 2021-02-17 15:20:10 PST

Comment on attachment 420730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420730&action=review > Source/WTF/ChangeLog:3 > + experiment with using the theme-color as the scroll area background if provided Title could use some ... title casing. Or y'know at least a starting capital. > Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:781 > + humanReadableName: "Use theme-color for scroll area background color" > + humanReadableDescription: "Use theme-color for scroll area background color" I hover the first string and see the second? Now I've wasted 3 seconds of my life. I would try shortening up the first one, it's pretty long for a menu item > Source/WebKit/UIProcess/ViewSnapshotStore.cpp:99 > + backgroundColor = webPageProxy.themeColor(); > + if (!backgroundColor.isValid()) Maybe a WebPageProxy getter to share this with WKWebViewIOS?

Devin Rousso

Comment 4 2021-02-17 15:48:02 PST

Comment on attachment 420730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=420730&action=review >> Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml:781 >> + humanReadableDescription: "Use theme-color for scroll area background color" > > I hover the first string and see the second? Now I've wasted 3 seconds of my life. > > I would try shortening up the first one, it's pretty long for a menu item talked offline about this and since it's an internal setting (and the existing title is already pretty succinct) i'll leave this as is >> Source/WebKit/UIProcess/ViewSnapshotStore.cpp:99 >> + if (!backgroundColor.isValid()) > > Maybe a WebPageProxy getter to share this with WKWebViewIOS? smart

Devin Rousso

Comment 5 2021-02-17 15:49:14 PST

Created attachment 420737 [details] Patch

Devin Rousso

Comment 6 2021-02-17 15:52:21 PST

Created attachment 420742 [details] Patch

Devin Rousso

Comment 7 2021-02-17 15:57:27 PST

Created attachment 420743 [details] Patch

Devin Rousso

Comment 8 2021-02-17 16:11:17 PST

Created attachment 420751 [details] Patch