Bug 220947

Summary: [iOS] imported/w3c/web-platform-tests/css/css-color/system-color-compute.html is failing
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: CSSAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=220247
Attachments:
Description Flags
Patch
none
Patch none

Ryan Haddad
Reported 2021-01-25 14:21:46 PST
imported/w3c/web-platform-tests/css/css-color/system-color-compute.html has been failing on iOS bots since it was imported with https://trac.webkit.org/changeset/271798/webkit: --- /Volumes/Data/slave/ios-simulator-14-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/css/css-color/system-color-compute-expected.txt +++ /Volumes/Data/slave/ios-simulator-14-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/css/css-color/system-color-compute-actual.txt @@ -2,7 +2,7 @@ Specified Child Inherit Child -FAIL color-scheme property affects Menu system color keyword assert_not_equals: got disallowed value "rgb(246, 246, 246)" +FAIL color-scheme property affects Menu system color keyword assert_not_equals: got disallowed value "rgb(192, 192, 192)" PASS System color computes to itself on color FAIL Inherited system color keyword is observable on color document.getElementById("inherited").computedStyleMap is not a function. (In 'document.getElementById("inherited").computedStyleMap()', 'document.getElementById("inherited").computedStyleMap' is undefined) PASS System color computes to itself on background-color https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-color%2Fsystem-color-compute.html
Attachments
Patch (5.47 KB, patch)
2021-01-25 15:20 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (6.01 KB, patch)
2021-01-25 15:22 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-25 14:21:58 PST
<rdar://problem/73588291>
Ryan Haddad
Comment 2 2021-01-25 14:25:32 PST
Marked test as failing in r271859
Ryan Haddad
Comment 3 2021-01-25 14:28:19 PST
Perhaps this can just be rebaselined for iOS since this subtest is already failing?
Sam Weinig
Comment 4 2021-01-25 15:15:17 PST
Fixing.
Sam Weinig
Comment 5 2021-01-25 15:20:43 PST
Created attachment 418342 [details] Patch
Sam Weinig
Comment 6 2021-01-25 15:22:11 PST
Created attachment 418343 [details] Patch
EWS
Comment 7 2021-01-27 11:20:30 PST
Committed r271968: <https://trac.webkit.org/changeset/271968> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418343 [details].
Note You need to log in before you can comment on or make changes to this bug.