Bug 215224

Summary: [WebXR] Update WebXR WPT directory
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aperez, cgarcia, clopez, darin, dino, ews-watchlist, svillar, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch youennf: review+

Sergio Villar Senin
Reported 2020-08-06 10:15:45 PDT
[WebXR] Update WebXR WPT directory
Attachments
Patch (154.39 KB, patch)
2020-08-06 10:29 PDT, Sergio Villar Senin 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-08-06 10:29:20 PDT
Created attachment 406090 [details] Patch
Sergio Villar Senin
Comment 2 2020-08-11 00:47:06 PDT
Ping reviewers
youenn fablet
Comment 3 2020-08-11 01:26:25 PDT
Comment on attachment 406090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406090&action=review > Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp:41 > +} Could be inline > LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html:139 > + debug('got viewerSpace'); Is it expected logging? > LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html:206 > + debug('got rAF 1'); Ditto.
Sergio Villar Senin
Comment 4 2020-08-12 00:42:12 PDT
Comment on attachment 406090 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406090&action=review Thanks for the review! >> Source/WebCore/Modules/webxr/WebXRInputSourceArray.cpp:41 >> +} > > Could be inline OK. I'll move it. >> LayoutTests/imported/w3c/web-platform-tests/webxr/dom-overlay/ar_dom_overlay.https.html:139 >> + debug('got viewerSpace'); > > Is it expected logging? This come straight from upstream. In our case it does not matter much because the debug() call is only implemented by Chromium AFAIK. For the rest of engines is an empty implementation. But I agree that it's weird to upstream something with debug statements.
Sergio Villar Senin
Comment 5 2020-08-12 04:06:55 PDT
Committed r265546: <https://trac.webkit.org/changeset/265546>
Radar WebKit Bug Importer
Comment 6 2020-08-12 04:07:19 PDT
<rdar://problem/66899462>
Note You need to log in before you can comment on or make changes to this bug.