Bug 213509

Summary: [WebXR] Fix PlatformXR initialization/destruction
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, dino, pnormand, svillar, webkit-bug-importer, youennf, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 208988    
Attachments:
Description Flags
Patch youennf: review+

Sergio Villar Senin
Reported 2020-06-23 04:50:25 PDT
[WebXR] Fix PlatformXR initialization/destruction
Attachments
Patch (2.96 KB, patch)
2020-06-23 05:06 PDT, Sergio Villar Senin 		youennf: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Villar Senin
Comment 1 2020-06-23 05:06:30 PDT
Created attachment 402545 [details] Patch
youenn fablet
Comment 2 2020-06-23 06:18:54 PDT
Comment on attachment 402545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review > Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218 > s_instance->m_impl = makeUnique<Impl>(); Can we do this assignment in Instance constructor? And make m_impl a UniqueRef<> maybe?
Sergio Villar Senin
Comment 3 2020-06-24 01:42:29 PDT
Comment on attachment 402545 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=402545&action=review Thanks for the review! >> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218 >> s_instance->m_impl = makeUnique<Impl>(); > > Can we do this assignment in Instance constructor? > And make m_impl a UniqueRef<> maybe? Makes total sense.
Sergio Villar Senin
Comment 4 2020-06-24 01:50:13 PDT
Committed r263447: <https://trac.webkit.org/changeset/263447>
Radar WebKit Bug Importer
Comment 5 2020-06-24 01:51:15 PDT
<rdar://problem/64690849>
Note You need to log in before you can comment on or make changes to this bug.