Bug 203194

Summary: [GStreamer] Several issues while trying to play a video on NextCloud
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: WebKitGTKAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aboya, berto, bugs-noreply, calvaris, cgarcia, commit-queue, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, pnormand, sergio, vjaquez
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Sergio Villar Senin
Reported 2019-10-21 07:50:25 PDT
I'm experiencing several issues when trying to play a video hosted on a nextcloud installation: * the playback is choppy, it starts, then I got several cuts and finally it becomes stalled * the download bar grows a bit and then stops * the progress indicator behaviour is weird, as it moves faster than the download bar Note that the video plays fine if I download it. PS: the aforementioned video is hosted in a private installation, I can give further details privately.
Attachments
Patch (11.67 KB, patch)
2019-11-12 03:37 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.63 KB, patch)
2019-11-12 07:03 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.63 KB, patch)
2019-11-12 07:04 PST, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2019-10-21 07:54:06 PDT
Most likely an issue in the GStreamer webkithttpsrc element.
Xabier Rodríguez Calvar
Comment 2 2019-11-12 03:37:33 PST
Created attachment 383346 [details] Patch
Philippe Normand
Comment 3 2019-11-12 03:45:03 PST
Comment on attachment 383346 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383346&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:468 > - && (GST_STATE(src) == GST_STATE_PLAYING) && priv->isDownloadSuspended) { > + && (GST_STATE(src) == GST_STATE_PLAYING || GST_STATE(src) == GST_STATE_PAUSED) && priv->isDownloadSuspended) { Could be simplified to GST_STATE(src) >= GST_STATE_PAUSED > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:38 > +#define WEBKIT_WEB_SRC_CAST(obj) ((WebKitWebSrc*)(obj)) Odd indentation here :)
Xabier Rodríguez Calvar
Comment 4 2019-11-12 07:03:14 PST
Created attachment 383351 [details] Patch for landing
Xabier Rodríguez Calvar
Comment 5 2019-11-12 07:04:48 PST
Created attachment 383352 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-11-13 02:44:05 PST
Comment on attachment 383352 [details] Patch for landing Clearing flags on attachment: 383352 Committed r252398: <https://trac.webkit.org/changeset/252398>
WebKit Commit Bot
Comment 7 2019-11-13 02:44:07 PST
All reviewed patches have been landed. Closing bug.
Xabier Rodríguez Calvar
Comment 8 2019-11-14 07:42:47 PST
I could reproduce this bug again.
Philippe Normand
Comment 9 2019-11-21 02:59:21 PST
*** Bug 204410 has been marked as a duplicate of this bug. ***
Philippe Normand
Comment 10 2019-12-17 01:53:49 PST
With current ToT here playback doesn't even start... The pipeline seems stuck in an ASYNC state change.
Xabier Rodríguez Calvar
Comment 11 2019-12-17 02:48:22 PST
Have you tried patch for bug 205275 ?
Philippe Normand
Comment 12 2019-12-17 02:51:55 PST
(In reply to Xabier Rodríguez Calvar from comment #11) > Have you tried patch for bug 205275 ? Yes and the video plays now. I was just saying the original issue reported is now different from what I observe without patches.
Xabier Rodríguez Calvar
Comment 13 2019-12-17 03:09:21 PST
(In reply to Philippe Normand from comment #12) > Yes and the video plays now. I was just saying the original issue reported > is now different from what I observe without patches. I observed several of this things while working on this bug that I tried to fix but as the patch was getting big, I thought I could push what I had and tackle the "low bandwidth pause" back here.
Alicia Boya García
Comment 14 2020-05-12 07:21:26 PDT
The video is working fine after the WebKitWebSrc threading rework. *** This bug has been marked as a duplicate of bug 210284 ***
Note You need to log in before you can comment on or make changes to this bug.