Bug 202838

Summary: String.prototype.matchAll should throw on non-global regex
Product: WebKit Reporter: Ross Kirsling <ross.kirsling>
Component: JavaScriptCoreAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 202861    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Ross Kirsling
Reported 2019-10-10 20:14:52 PDT
String.prototype.matchAll should throw on non-global regex
Attachments
Patch (8.91 KB, patch)
2019-10-10 20:21 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch (8.93 KB, patch)
2019-10-23 10:00 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Patch for landing (8.93 KB, patch)
2019-10-23 10:08 PDT, Ross Kirsling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ross Kirsling
Comment 1 2019-10-10 20:21:55 PDT
Created attachment 380717 [details] Patch
Ross Kirsling
Comment 2 2019-10-10 20:26:06 PDT
We'll need one more test262 update before landing this, as working on this patch had revealed some issues (https://github.com/tc39/test262/pull/2399).
Ross Kirsling
Comment 3 2019-10-11 11:34:55 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 4 2019-10-23 08:05:56 PDT
Ping, perchance?
Keith Miller
Comment 5 2019-10-23 09:51:11 PDT
Comment on attachment 380717 [details] Patch seems reasonable. I'm assuming the `matchAll()` entry code is not a perf bottleneck and the real work happens inside the `regExp.@matchAllSymbol()` call?
Ross Kirsling
Comment 6 2019-10-23 10:00:23 PDT Comment hidden (obsolete)
Ross Kirsling
Comment 7 2019-10-23 10:03:53 PDT
(In reply to Keith Miller from comment #5) > Comment on attachment 380717 [details] > Patch > > seems reasonable. I'm assuming the `matchAll()` entry code is not a perf > bottleneck and the real work happens inside the `regExp.@matchAllSymbol()` > call? Yeah, exactly.
Ross Kirsling
Comment 8 2019-10-23 10:08:12 PDT
Created attachment 381688 [details] Patch for landing
WebKit Commit Bot
Comment 9 2019-10-23 11:45:44 PDT
Comment on attachment 381688 [details] Patch for landing Clearing flags on attachment: 381688 Committed r251483: <https://trac.webkit.org/changeset/251483>
WebKit Commit Bot
Comment 10 2019-10-23 11:45:46 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-10-23 11:48:38 PDT
<rdar://problem/56547782>
Note You need to log in before you can comment on or make changes to this bug.