Bug 202100

Summary: [Nicosia] Add implementations for fixed, positioned, sticky ScrollingTreeNodes
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cgarcia, cmarcelo, ews-watchlist, fred.wang, gyuyoung.kim, jamesr, luiz, rakuco, ryuan.choi, sergio, tonikitoo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 198475    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2019-09-23 03:02:09 PDT
[Nicosia] Add implementations for fixed, positioned, sticky ScrollingTreeNodes
Attachments
Patch (24.85 KB, patch)
2019-09-23 03:23 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (24.73 KB, patch)
2019-09-25 02:46 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2019-09-23 03:23:29 PDT
Created attachment 379363 [details] Patch
Carlos Garcia Campos
Comment 2 2019-09-24 04:17:43 PDT
Comment on attachment 379363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379363&action=review > Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:88 > + }(); What's the point of the lambda here? > Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.h:43 > +class ScrollingTreePositionedNode : public ScrollingTreeNode { is this final class?
Zan Dobersek
Comment 3 2019-09-24 05:46:29 PDT
Comment on attachment 379363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=379363&action=review >> Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp:88 >> + }(); > > What's the point of the lambda here? OK, I'll flatten it.
Zan Dobersek
Comment 4 2019-09-25 02:46:52 PDT
Created attachment 379533 [details] Patch for landing
Zan Dobersek
Comment 5 2019-09-25 02:47:52 PDT
Comment on attachment 379533 [details] Patch for landing Clearing flags on attachment: 379533 Committed r250339: <https://trac.webkit.org/changeset/250339>
Zan Dobersek
Comment 6 2019-09-25 02:47:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-09-25 02:48:19 PDT
<rdar://problem/55697583>
Note You need to log in before you can comment on or make changes to this bug.