Bug 201286

Summary: Simplify PLATFORM expression
Product: WebKit Reporter: Keith Rollin <krollin>
Component: Tools / TestsAssignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, jer.noble, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200694
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-08-28 21:21:20 PDT
The preprocessor expression conditionalizing the inclusion of the body of ExitFullscreenOnEnterPiP.mm evolved into: #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)) Simplify this to just: #if !PLATFORM(IOS_FAMILY_SIMULATOR)
Attachments
Patch (1.50 KB, patch)
2019-08-29 15:53 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-28 21:21:33 PDT
<rdar://problem/54822347>
Keith Rollin
Comment 2 2019-08-29 15:53:02 PDT
Created attachment 377645 [details] Patch
Alexey Proskuryakov
Comment 3 2019-08-29 19:29:30 PDT
Comment on attachment 377645 [details] Patch I suspect that this conditional was meant for iOS only, and “family” came from a global rename.
WebKit Commit Bot
Comment 4 2019-08-30 08:44:46 PDT
Comment on attachment 377645 [details] Patch Clearing flags on attachment: 377645 Committed r249328: <https://trac.webkit.org/changeset/249328>
WebKit Commit Bot
Comment 5 2019-08-30 08:44:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.