Bug 201282

Summary: Remove 32-bit macOS support
Product: WebKit Reporter: Keith Rollin <krollin>
Component: WebKit Misc.Assignee: Keith Rollin <krollin>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=200694
Attachments:
Description Flags
Patch none

Keith Rollin
Reported 2019-08-28 20:46:28 PDT
WebKit doesn’t support 32-bit Mac any more, so remove checks and code for that platform.
Attachments
Patch (3.59 KB, patch)
2019-08-29 15:49 PDT, Keith Rollin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-08-28 20:46:42 PDT
<rdar://problem/54821667>
Keith Rollin
Comment 2 2019-08-29 15:49:39 PDT
Created attachment 377642 [details] Patch
Anders Carlsson
Comment 3 2019-08-29 15:55:24 PDT
Comment on attachment 377642 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=377642&action=review > Source/JavaScriptCore/API/JSBase.h:149 > #define JSC_OBJC_API_ENABLED 1 Does this mean that JSC_OBJC_API_ENABLED is always 1 now?
Keith Rollin
Comment 4 2019-08-29 15:58:40 PDT
(In reply to Anders Carlsson from comment #3) > Comment on attachment 377642 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=377642&action=review > > > Source/JavaScriptCore/API/JSBase.h:149 > > #define JSC_OBJC_API_ENABLED 1 > > Does this mean that JSC_OBJC_API_ENABLED is always 1 now? It looks like it is for Cocoa. We can clean up the conditional around that in a follow-up patch.
WebKit Commit Bot
Comment 5 2019-08-29 17:39:38 PDT
Comment on attachment 377642 [details] Patch Clearing flags on attachment: 377642 Committed r249304: <https://trac.webkit.org/changeset/249304>
WebKit Commit Bot
Comment 6 2019-08-29 17:39:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.