Bug 182883

Summary: [CMake][Win] Use cmakeconfig.h rather than config.h and Platform.h
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, bfulgham, commit-queue, lforschler, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Don Olmstead
Reported 2018-02-16 13:28:54 PST
Currently a lot of things within Platform.h and the individual config.h files could be defined in CMake rather than in config.h files. This should hopefully be less error prone than what the config.h files do. Ports should use SET_AND_EXPOSE_TO_BUILD whenever possible.
Attachments
Patch (11.33 KB, patch)
2018-02-20 13:05 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.67 KB, patch)
2018-02-20 15:26 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.68 KB, patch)
2018-02-20 15:27 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (11.58 KB, patch)
2018-02-20 15:35 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (10.92 KB, patch)
2018-02-20 16:47 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (10.93 KB, patch)
2018-02-20 16:49 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2018-02-20 13:05:03 PST
Created attachment 334296 [details] Patch Moves a bunch of things to CMake. _WINSOCKAPI_ is defined on WinCairo since it uses Curl.
Don Olmstead
Comment 2 2018-02-20 15:26:42 PST
Created attachment 334306 [details] Patch
Don Olmstead
Comment 3 2018-02-20 15:27:45 PST
Created attachment 334307 [details] Patch
Don Olmstead
Comment 4 2018-02-20 15:35:11 PST
Created attachment 334308 [details] Patch
Don Olmstead
Comment 5 2018-02-20 16:47:12 PST
Created attachment 334319 [details] Patch
Don Olmstead
Comment 6 2018-02-20 16:49:57 PST
Created attachment 334320 [details] Patch
Konstantin Tokarev
Comment 7 2018-02-20 17:10:55 PST
LGTM, if there are no special reasons for AppleWin to prefer Platform.h
Per Arne Vollan
Comment 8 2018-02-21 10:16:59 PST
(In reply to Konstantin Tokarev from comment #7) > LGTM, if there are no special reasons for AppleWin to prefer Platform.h From an AppleWin standpoint, I also believe this looks good. Alex, Brent, what do you say?
Per Arne Vollan
Comment 9 2018-02-21 10:19:50 PST
Comment on attachment 334320 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334320&action=review > Source/cmake/OptionsAppleWin.cmake:-11 > -set(USE_ICU_UNICODE 1) Is this not needed anymore?
Konstantin Tokarev
Comment 10 2018-02-21 10:27:25 PST
(In reply to Per Arne Vollan from comment #9) > > -set(USE_ICU_UNICODE 1) > > Is this not needed anymore? It was removed from code in r162782
Per Arne Vollan
Comment 11 2018-02-21 11:21:14 PST
Comment on attachment 334320 [details] Patch R=me.
WebKit Commit Bot
Comment 12 2018-02-21 12:01:27 PST
Comment on attachment 334320 [details] Patch Clearing flags on attachment: 334320 Committed r228891: <https://trac.webkit.org/changeset/228891>
WebKit Commit Bot
Comment 13 2018-02-21 12:01:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2018-02-21 12:02:29 PST
<rdar://problem/37755787>
Note You need to log in before you can comment on or make changes to this bug.