Bug 178024

Summary:

[WinCairo] add WebProcess files for wincairo webkit

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, basuke, bfulgham, buildbot, commit-queue, don.olmstead, webkit-bug-importer, Yousuke.Kimoto

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Add initial versions of WebProcess files for wincairo webkit	none
Add initial versions of WebProcess files for wincairo webkit, fixed style	achristensen: review-
Add initial versions of WebProcess files for wincairo webkit, removed if 0ed code	none
Add initial versions of WebProcess files for wincairo webkit, dummy injected bundle initialization	none

Stephan Szabo

Reported 2017-10-06 12:41:15 PDT

Add WebProcess files for WinCairo WebKit build.

Attachments
Add initial versions of WebProcess files for wincairo webkit (36.56 KB, patch) 2017-10-10 10:19 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Add initial versions of WebProcess files for wincairo webkit, fixed style (36.88 KB, patch) 2017-10-10 10:31 PDT, Stephan Szabo	achristensen: review-	Details Formatted Diff Diff
Add initial versions of WebProcess files for wincairo webkit, removed if 0ed code (36.65 KB, patch) 2017-10-12 14:50 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Add initial versions of WebProcess files for wincairo webkit, dummy injected bundle initialization (36.33 KB, patch) 2017-10-12 14:51 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Stephan Szabo

Comment 1 2017-10-10 10:19:54 PDT

Created attachment 323314 [details] Add initial versions of WebProcess files for wincairo webkit

Build Bot

Comment 2 2017-10-10 10:21:23 PDT

Attachment 323314 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:84: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:146: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:154: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:155: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:156: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:160: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:161: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:162: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:166: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:166: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:167: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:167: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:168: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:168: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:169: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:169: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:170: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:170: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:171: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:171: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:172: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:172: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:173: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:173: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:174: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:174: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:175: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:175: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:176: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:176: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:177: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:177: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:178: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:178: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:179: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:179: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:180: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:180: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:181: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:181: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:182: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:182: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:183: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:183: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:184: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:184: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:185: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:185: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:187: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:187: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:188: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:188: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:189: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:189: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:190: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:190: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:192: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:192: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:193: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:193: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:194: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:194: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:195: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:195: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:196: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:196: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:198: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:198: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:199: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:199: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:201: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:201: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:202: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:202: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:203: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:203: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:204: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:204: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:205: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:205: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:206: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:206: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:207: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:207: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:208: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:208: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:209: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:209: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:211: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:212: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:213: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:213: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:214: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:214: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:215: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:215: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:216: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:216: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:217: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:217: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:218: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:218: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:219: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:219: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:220: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:220: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:221: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:221: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:225: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:225: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:226: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:226: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:227: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:227: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:228: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:228: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:229: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:229: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:230: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:230: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:231: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:231: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:236: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:238: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:239: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:241: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:242: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:243: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:245: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:246: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:248: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:249: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:250: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:252: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:253: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:254: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:255: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:256: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:257: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:258: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage /win/WebPageWin.cpp:260: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:261: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:262: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:263: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:265: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp:266: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebPage/win/WebInspectorUIWin.cpp:27: You should add a blank line after implementation file's own header. [build/include_order] [4] ERROR: Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:48: Tab found; better to use spaces [whitespace/tab] [1] ERROR: Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h:51: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 149 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Stephan Szabo

Comment 3 2017-10-10 10:31:50 PDT

Created attachment 323316 [details] Add initial versions of WebProcess files for wincairo webkit, fixed style

Alex Christensen

Comment 4 2017-10-12 13:34:43 PDT

Comment on attachment 323316 [details] Add initial versions of WebProcess files for wincairo webkit, fixed style View in context: https://bugs.webkit.org/attachment.cgi?id=323316&action=review > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:40 > +bool InjectedBundle::initialize(const WebProcessCreationParameters&, API::Object* initializationUserData) Do we need to use the InjectedBundle on Windows? Couldn't we just leave this uninitialized? We're trying to reduce/remove the need for this by going through our use cases that "require" it right now and designing API to do that from the UIProcess. > Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp:49 > +#if 0 Let's not.

Stephan Szabo

Comment 5 2017-10-12 14:08:51 PDT

> > Source/WebKit/WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:40 > > +bool InjectedBundle::initialize(const WebProcessCreationParameters&, API::Object* initializationUserData) >Do we need to use the InjectedBundle on Windows? Couldn't we just leave this >uninitialized? We're trying to reduce/remove the need for this by going >through our use cases that "require" it right now and designing API to do >that from the UIProcess. I think that had been added for things in Tools like WebKitTestRunner, but if those aren't using it then I don't think we would need it. Will remove the #if 0ed code.

Stephan Szabo

Comment 6 2017-10-12 14:50:05 PDT

Created attachment 323569 [details] Add initial versions of WebProcess files for wincairo webkit, removed if 0ed code

Stephan Szabo

Comment 7 2017-10-12 14:51:45 PDT

Created attachment 323570 [details] Add initial versions of WebProcess files for wincairo webkit, dummy injected bundle initialization Also version with the IB intialization stubbed to returning false. Looking to see what doesn't work if we just don't have implementations of those at all.

WebKit Commit Bot

Comment 8 2017-10-12 15:36:58 PDT

Comment on attachment 323570 [details] Add initial versions of WebProcess files for wincairo webkit, dummy injected bundle initialization Clearing flags on attachment: 323570 Committed r223262: <https://trac.webkit.org/changeset/223262>

WebKit Commit Bot

Comment 9 2017-10-12 15:37:00 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2017-10-12 15:38:30 PDT

<rdar://problem/34965644>

Note You need to log in before you can comment on or make changes to this bug.