Bug 173614

Summary: Have FrameLoadRequest take a Frame& instead of a Frame*
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, buildbot, cdumez, darin, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173564    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch bfulgham: review+, bfulgham: commit-queue-

Daniel Bates
Reported 2017-06-20 12:44:05 PDT
Splitting off from bug #173564. Have the FrameLoadRequest constructor that takes a frame take it by reference instead of by pointer as we assume the frame is non-null.
Attachments
Patch (17.09 KB, patch)
2017-06-20 12:45 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (17.09 KB, patch)
2017-06-20 12:46 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (17.10 KB, patch)
2017-06-20 12:48 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch (17.75 KB, patch)
2017-06-20 13:52 PDT, Daniel Bates 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2017-06-20 12:45:22 PDT
Created attachment 313423 [details] Patch
Daniel Bates
Comment 2 2017-06-20 12:46:31 PDT
Created attachment 313424 [details] Patch
Build Bot
Comment 3 2017-06-20 12:48:01 PDT
Attachment 313424 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FrameLoadRequest.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 4 2017-06-20 12:48:26 PDT
Created attachment 313425 [details] Patch
Build Bot
Comment 5 2017-06-20 12:50:46 PDT
Attachment 313425 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FrameLoadRequest.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 6 2017-06-20 13:52:35 PDT
Created attachment 313435 [details] Patch
Build Bot
Comment 7 2017-06-20 13:53:45 PDT
Attachment 313435 [details] did not pass style-queue: ERROR: Source/WebCore/loader/FrameLoadRequest.cpp:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 8 2017-06-20 15:26:48 PDT
Comment on attachment 313435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=313435&action=review r=me > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=173614 Please import to Radar.
Radar WebKit Bug Importer
Comment 9 2017-06-20 15:38:30 PDT
<rdar://problem/32884890>
Daniel Bates
Comment 10 2017-06-20 15:45:28 PDT
Committed r218611: <http://trac.webkit.org/changeset/218611>
Note You need to log in before you can comment on or make changes to this bug.