Bug 172245

Summary: [MediaStream] do not cache gUM permissions
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
youennf: review+
Patch for landing.
none
Patch for landing.
none
Patch for landing.
none
Patch for landing. none

Eric Carlson
Reported 2017-05-17 14:57:02 PDT
WebKit should alway ask the user agent for permission to access devices. The user agent can choose to cache responses if it wants to.
Attachments
Proposed patch. (27.12 KB, patch)
2017-05-18 06:35 PDT, Eric Carlson 		youennf: review+
DetailsFormatted DiffDiff
Patch for landing. (27.17 KB, patch)
2017-05-18 10:26 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (29.66 KB, patch)
2017-05-18 10:45 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (22.55 KB, patch)
2017-05-18 11:57 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch for landing. (31.91 KB, patch)
2017-05-18 13:10 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2017-05-18 06:35:21 PDT
Created attachment 310505 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2017-05-18 06:36:00 PDT
<rdar://problem/32271110>
youenn fablet
Comment 3 2017-05-18 08:03:56 PDT
Comment on attachment 310505 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=310505&action=review > Source/WebKit2/UIProcess/UserMediaPermissionRequestProxy.cpp:41 > + , m_deviceIdentifierHashSalt(deviceIDHashSalt) WTFMove
Eric Carlson
Comment 4 2017-05-18 10:26:35 PDT
Created attachment 310515 [details] Patch for landing.
Eric Carlson
Comment 5 2017-05-18 10:45:56 PDT
Created attachment 310519 [details] Patch for landing.
Eric Carlson
Comment 6 2017-05-18 11:57:28 PDT
Created attachment 310525 [details] Patch for landing.
Eric Carlson
Comment 7 2017-05-18 13:10:43 PDT
Created attachment 310541 [details] Patch for landing.
WebKit Commit Bot
Comment 8 2017-05-18 18:16:51 PDT
Comment on attachment 310541 [details] Patch for landing. Clearing flags on attachment: 310541 Committed r217081: <http://trac.webkit.org/changeset/217081>
Ahmad Saleem
Comment 9 2022-10-05 16:22:43 PDT
It seems landed but didn't backed out based on each on Webkit GitHub with BugID: https://github.com/WebKit/WebKit/commit/39b1840ee9c0a82b8944dd902415b78d7838c083 Marking this as "RESOLVED FIXED". Thanks!
Note You need to log in before you can comment on or make changes to this bug.