Bug 164457

Summary: Move Range from ExceptionCode to ExceptionOr
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 164515, 164516    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Darin Adler
Reported 2016-11-05 16:51:45 PDT
Move Range from ExceptionCode to ExceptionOr
Attachments
Patch (166.88 KB, patch)
2016-11-05 22:36 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (168.37 KB, patch)
2016-11-05 22:53 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (170.10 KB, patch)
2016-11-06 10:15 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (170.10 KB, patch)
2016-11-06 10:35 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (171.21 KB, patch)
2016-11-07 19:39 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (171.85 KB, patch)
2016-11-07 19:57 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (173.83 KB, patch)
2016-11-07 21:52 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (176.03 KB, patch)
2016-11-07 22:57 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (181.17 KB, patch)
2016-11-07 23:34 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-11-05 22:36:29 PDT
Created attachment 294016 [details] Patch
Darin Adler
Comment 2 2016-11-05 22:53:30 PDT
Created attachment 294017 [details] Patch
Darin Adler
Comment 3 2016-11-06 10:15:44 PST
Created attachment 294025 [details] Patch
Darin Adler
Comment 4 2016-11-06 10:35:08 PST
Created attachment 294026 [details] Patch
Darin Adler
Comment 5 2016-11-07 19:39:04 PST
Created attachment 294124 [details] Patch
Darin Adler
Comment 6 2016-11-07 19:57:47 PST
Created attachment 294127 [details] Patch
Darin Adler
Comment 7 2016-11-07 21:52:15 PST
Created attachment 294134 [details] Patch
Darin Adler
Comment 8 2016-11-07 22:57:53 PST
Created attachment 294137 [details] Patch
Darin Adler
Comment 9 2016-11-07 23:34:45 PST
Created attachment 294139 [details] Patch
Darin Adler
Comment 10 2016-11-07 23:54:02 PST
Comment on attachment 294139 [details] Patch Patch passing on EWS and ready for review now.
Alex Christensen
Comment 11 2016-11-08 10:11:04 PST
Comment on attachment 294139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=294139&action=review > Source/WebCore/accessibility/AXObjectCache.cpp:1691 > + if (result.hasException()) > + return true; This check for exceptions wasn't there before. I guess we're becoming safer? > Source/WebCore/rendering/RenderNamedFlowThread.cpp:700 > + if (!intersectsResult.hasException() && intersectsResult.releaseReturnValue()) ditto
WebKit Commit Bot
Comment 12 2016-11-09 13:31:01 PST
Comment on attachment 294139 [details] Patch Clearing flags on attachment: 294139 Committed r208479: <http://trac.webkit.org/changeset/208479>
WebKit Commit Bot
Comment 13 2016-11-09 13:31:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.