Bug 159795

Summary: Make ImageFrame and ImageFrameData be equivalent so ImageFrameData can be removed
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: beidson, sam, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159721    
Bug Blocks: 155322, 159819    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for review none

Said Abou-Hallawa
Reported 2016-07-14 16:59:23 PDT
This step will allow removing ImageFrame from platform/image-decoders/ImageDecoder.h and renaming ImageFrameData to be ImageFrame.
Attachments
Patch (205.81 KB, patch)
2016-07-14 17:27 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (205.79 KB, patch)
2016-07-14 17:56 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (205.79 KB, patch)
2016-07-14 18:28 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (205.79 KB, patch)
2016-07-14 18:37 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (57.78 KB, patch)
2016-07-15 10:15 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2016-07-14 17:27:58 PDT
Created attachment 283714 [details] Patch
Said Abou-Hallawa
Comment 2 2016-07-14 17:56:35 PDT
Created attachment 283721 [details] Patch
Said Abou-Hallawa
Comment 3 2016-07-14 18:28:54 PDT
Created attachment 283726 [details] Patch
Said Abou-Hallawa
Comment 4 2016-07-14 18:37:15 PDT
Created attachment 283729 [details] Patch
Said Abou-Hallawa
Comment 5 2016-07-15 10:15:15 PDT
Created attachment 283769 [details] Patch for review
Said Abou-Hallawa
Comment 6 2016-09-15 14:28:31 PDT
https://bugs.webkit.org/show_bug.cgi?id=159819 *** This bug has been marked as a duplicate of bug 159819 ***
Brady Eidson
Comment 7 2017-08-19 16:02:38 PDT
Comment on attachment 283769 [details] Patch for review r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Said Abou-Hallawa
Comment 8 2017-08-21 12:15:27 PDT
Comment on attachment 283769 [details] Patch for review This bug was marked as s duplicate. I was not aware that duplicate bugs can also appear as requesting-review bugs. I think removing the flags is more appropriate in this case.
Note You need to log in before you can comment on or make changes to this bug.