Bug 158606

Summary: ErrorEvent / ProgressEvent should be exposed to workers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, darin, esprehn+autocc, kangil.han, kondapallykalyan, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Attachments
Patch (5.36 KB, patch)
2016-06-09 22:14 PDT, Chris Dumez
no flags
Chris Dumez
Comment 1 2016-06-09 22:14:26 PDT
Alex Christensen
Comment 2 2016-06-10 00:15:55 PDT
Comment on attachment 280992 [details] Patch Actually, I'm not sure. ErrorEvent::createForBindings uses an AtomicString, and can't that only be used from the main thread?
Chris Dumez
Comment 3 2016-06-10 07:23:54 PDT
(In reply to comment #2) > Comment on attachment 280992 [details] > Patch > > Actually, I'm not sure. ErrorEvent::createForBindings uses an AtomicString, > and can't that only be used from the main thread? Using AtomicString in other threads is fine. What you cannot do is pass them to other threads. AtomicStrings are per thread AFAIK.
Brady Eidson
Comment 4 2016-06-10 09:04:31 PDT
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 280992 [details] > > Patch > > > > Actually, I'm not sure. ErrorEvent::createForBindings uses an AtomicString, > > and can't that only be used from the main thread? > > Using AtomicString in other threads is fine. What you cannot do is pass them > to other threads. AtomicStrings are per thread AFAIK. This is correct - Each thread has its own AtomicString table, and its safe to use them within a given thread.
Chris Dumez
Comment 5 2016-06-10 09:18:14 PDT
Comment on attachment 280992 [details] Patch Clearing flags on attachment: 280992 Committed r201926: <http://trac.webkit.org/changeset/201926>
Chris Dumez
Comment 6 2016-06-10 09:18:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.