Bug 156255
| Summary: | Refactor Windows/GTK/EFL usage of addHTTPHeaderField to send an HTTPHeaderName instead of a String | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 155602 | ||
| Bug Blocks: | |||
John Wilander
During the https://bugs.webkit.org/show_bug.cgi?id=155602 it was noted that Windows, GTK, and EFL call ResourceResponseBase::addHTTPHeaderField() with a String reference as the header name. We should refactor these pieces to instead use HTTPHeaderName::findHTTPHeaderName() and send a HTTPHeaderName enum value to esourceResponseBase::addHTTPHeaderField(). Thus, unknown header names can be handled where error handling makes more sense.
The same goes for ResourceRequestBase::addHTTPHeaderField().
After this refactoring it should be possible to remove the addHTTPHeaderField() functions that receive HTTP header names as strings.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |