Bug 155566

Summary: Make the ImageFrameDecoder notify the image observer when a frame image finishes decoding
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: ImagesAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED INVALID    
Severity: Normal CC: beidson, dino, jonlee, sam, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 155546    
Bug Blocks: 155322    
Attachments:
Description Flags
Patch
none
Patch for review none

Said Abou-Hallawa
Reported 2016-03-16 16:38:37 PDT
With the synchronous image, CachedImage::finishLoading() notifies the observers (which are the renderers) by calling CachedImage::notifyObservers(). With the asynchronous we need to do the same when a frame image finished decoding. Since ImageSource has a reference to an Image object, and the Image::m_observer is actually an instance of CachedImage, the calling sequence should be straightforward.
Attachments
Patch (190.88 KB, patch)
2016-03-16 16:59 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (5.08 KB, patch)
2016-03-16 18:24 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2016-03-16 16:59:25 PDT
Created attachment 274237 [details] Patch
Said Abou-Hallawa
Comment 2 2016-03-16 18:24:49 PDT
Created attachment 274250 [details] Patch for review
Simon Fraser (smfr)
Comment 3 2016-03-16 18:27:23 PDT
Comment on attachment 274250 [details] Patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=274250&action=review > Source/WebCore/loader/cache/CachedImage.cpp:482 > +void CachedImage::decodedImageChanged(const Image* image) Can this be a const Image&?
Brady Eidson
Comment 4 2017-08-19 16:01:05 PDT
Comment on attachment 274250 [details] Patch for review r-, as this has been pending review for over a year now. It is near-impossible that this patch still applies to trunk and unlikely to still be relevant in its current form.
Said Abou-Hallawa
Comment 5 2017-08-21 12:17:25 PDT
Comment on attachment 274250 [details] Patch for review This bug was marked as s invalid. I was not aware that duplicate bugs can also appear as requesting-review bugs. I think removing the flags is more appropriate in this case.
Note You need to log in before you can comment on or make changes to this bug.