Bug 146742

Summary: Media Session: indicate to clients whether a media session has active media elements
Product: WebKit Reporter: Matt Rajca <mrajca>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: conrad_shultz, eric.carlson, jer.noble, mrajca, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 145411    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Matt Rajca
Reported 2015-07-08 15:41:05 PDT
Indicate to clients whether there are active media elements in a media session.
Attachments
Patch (6.38 KB, patch)
2015-07-08 15:46 PDT, Matt Rajca 		no flags
DetailsFormatted DiffDiff
Patch (7.22 KB, patch)
2015-07-08 16:34 PDT, Matt Rajca 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-08 15:42:11 PDT
<rdar://problem/21734470>
Matt Rajca
Comment 2 2015-07-08 15:46:05 PDT
Created attachment 256412 [details] Patch
Tim Horton
Comment 3 2015-07-08 16:09:30 PDT
Comment on attachment 256412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256412&action=review > Source/WebKit2/UIProcess/API/C/WKPage.cpp:2156 > +bool WKPageHasActiveMediaElements(WKPageRef page) Seems pretty bizarre that something called this would return false if you have a <video> on the page (but have MEDIA_SESSION off)...
Matt Rajca
Comment 4 2015-07-08 16:13:28 PDT
(In reply to comment #3) > Comment on attachment 256412 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=256412&action=review > > > Source/WebKit2/UIProcess/API/C/WKPage.cpp:2156 > > +bool WKPageHasActiveMediaElements(WKPageRef page) > > Seems pretty bizarre that something called this would return false if you > have a <video> on the page (but have MEDIA_SESSION off)... I'll rename it to WKPageHasMediaSessionWithActiveMediaElements.
Matt Rajca
Comment 5 2015-07-08 16:34:55 PDT
Created attachment 256421 [details] Patch
Matt Rajca
Comment 6 2015-07-08 16:47:31 PDT
Committed r186538: <http://trac.webkit.org/changeset/186538>
Note You need to log in before you can comment on or make changes to this bug.