Bug 146356

Summary:

Test existence of controls on MediaSession

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, conrad_shultz, eric.carlson, jer.noble, mrajca, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-mavericks	none
Archive of layout-test-results from ews107 for mac-mavericks-wk2	none

Matt Rajca

Reported 2015-06-26 12:00:54 PDT

Only Media Sessions created with the "content" kind should have media remote controls.

Attachments
Patch (2.37 KB, patch) 2015-06-26 18:27 PDT, Matt Rajca	eric.carlson: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-mavericks (548.25 KB, application/zip) 2015-06-26 19:01 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (574.27 KB, application/zip) 2015-06-26 19:23 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-06-26 12:01:54 PDT

<rdar://problem/21569300>

Matt Rajca

Comment 2 2015-06-26 18:27:24 PDT

Created attachment 255682 [details] Patch

Build Bot

Comment 3 2015-06-26 19:01:18 PDT

Comment on attachment 255682 [details] Patch Attachment 255682 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5461893003083776 New failing tests: media/session/controls-existence.html

Build Bot

Comment 4 2015-06-26 19:01:23 PDT

Created attachment 255683 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5

Build Bot

Comment 5 2015-06-26 19:23:21 PDT

Comment on attachment 255682 [details] Patch Attachment 255682 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4581045944975360 New failing tests: media/session/controls-existence.html

Build Bot

Comment 6 2015-06-26 19:23:25 PDT

Created attachment 255684 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5

Eric Carlson

Comment 7 2015-06-27 07:27:13 PDT

Comment on attachment 255682 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255682&action=review > LayoutTests/ChangeLog:9 > + * media/session/controls-existence-expected.txt: Added. > + * media/session/controls-existence.html: Added. You need to mark the new test as Skipped in LayoutTests/platform/mac/TestExpectations. > LayoutTests/media/session/controls-existence-expected.txt:6 > +EXPECTED (session.controls != 'null') OK > +EXPECTED (session.controls == 'null') OK > +EXPECTED (session.controls == 'null') OK > +EXPECTED (session.controls == 'null') OK Nit: It can be helpful to have more context about what is being tested in the results, so it would be helpful to log the session type. For example: run("session = new MediaSession('content')"); testExpected("session.controls", null, '!='); or maybe testExpected("new MediaSession('content').controls", null, '!='); etc.

Matt Rajca

Comment 8 2015-06-29 09:49:55 PDT

(In reply to comment #7) > Comment on attachment 255682 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=255682&action=review > > > LayoutTests/ChangeLog:9 > > + * media/session/controls-existence-expected.txt: Added. > > + * media/session/controls-existence.html: Added. > > You need to mark the new test as Skipped in > LayoutTests/platform/mac/TestExpectations. Done. Wasn't sure if they were opt-in or opt-out. > > > LayoutTests/media/session/controls-existence-expected.txt:6 > > +EXPECTED (session.controls != 'null') OK > > +EXPECTED (session.controls == 'null') OK > > +EXPECTED (session.controls == 'null') OK > > +EXPECTED (session.controls == 'null') OK > > Nit: It can be helpful to have more context about what is being tested in > the results, so it would be helpful to log the session type. For example: > > run("session = new MediaSession('content')"); > testExpected("session.controls", null, '!='); I'll do that. > > or maybe > > testExpected("new MediaSession('content').controls", null, '!='); > > etc.

Matt Rajca

Comment 9 2015-06-29 09:51:41 PDT

Committed r186070: <http://trac.webkit.org/changeset/186070>

Note You need to log in before you can comment on or make changes to this bug.