Bug 145636

Summary: Fix options in build-jsc for CMake builds
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145516    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2015-06-03 23:18:09 PDT
Fix options in build-jsc for CMake builds
Attachments
Patch (1.39 KB, patch)
2015-06-03 23:20 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2015-06-03 23:20:54 PDT
Created attachment 254250 [details] Patch
Gyuyoung Kim
Comment 2 2015-06-03 23:41:20 PDT
Comment on attachment 254250 [details] Patch I can't find why did r185110 also modify cmake port on bug 145516. https://bugs.webkit.org/show_bug.cgi?id=145516 AFAIK, cmake port needs to use ON/OFF. If we set nothing, it is set to false. http://www.cmake.org/cmake/help/v3.0/command/option.html
WebKit Commit Bot
Comment 3 2015-06-03 23:49:53 PDT
Comment on attachment 254250 [details] Patch Clearing flags on attachment: 254250 Committed r185194: <http://trac.webkit.org/changeset/185194>
WebKit Commit Bot
Comment 4 2015-06-03 23:49:58 PDT
All reviewed patches have been landed. Closing bug.
Gyuyoung Kim
Comment 5 2015-06-03 23:59:05 PDT
One more thing, if we don't set value for passing arguments, cmake generates build error as below, ~/WebKit$ Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_INDEXED_DATABASE_IN_WORKERS" Not searching for unused variables given on the command line. Parse error in command line argument: -DENABLE_INDEXED_DATABASE_IN_WORKERS Should be: VAR:type=value CMake Error: No cmake script provided. CMake Error: Problem processing arguments. Aborting.
Note You need to log in before you can comment on or make changes to this bug.