Bug 145516

Summary: build-jsc’s —cloop option is broken
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145515, 145543    
Bug Blocks: 145636    
Attachments:
Description Flags
the patch.
none
patch 2: fixed non-ascii chars.
none
patch for re-landing. none

Mark Lam
Reported 2015-06-01 09:59:41 PDT
After r183516, build-jsc --cloop no longer builds the CLOOP interpreter. This is because it did not explicitly disable the JIT when --cloop is specified.
Attachments
the patch. (1.89 KB, patch)
2015-06-01 10:09 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch 2: fixed non-ascii chars. (1.89 KB, patch)
2015-06-01 10:12 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
patch for re-landing. (1.86 KB, patch)
2015-06-02 10:44 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2015-06-01 10:03:03 PDT
We cannot land this fix until https://bugs.webkit.org/show_bug.cgi?id=145515 is resolved. Otherwise, we’ll have a red CLoop bot. In reality, we do have a red CLoop bot. We just have not been building the CLoop and seeing it.
Mark Lam
Comment 2 2015-06-01 10:09:43 PDT
Created attachment 254005 [details] the patch.
Mark Lam
Comment 3 2015-06-01 10:12:11 PDT
Created attachment 254006 [details] patch 2: fixed non-ascii chars.
WebKit Commit Bot
Comment 4 2015-06-01 11:18:04 PDT
Comment on attachment 254006 [details] patch 2: fixed non-ascii chars. Clearing flags on attachment: 254006 Committed r185066: <http://trac.webkit.org/changeset/185066>
WebKit Commit Bot
Comment 5 2015-06-01 11:18:06 PDT
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 6 2015-06-01 20:17:18 PDT
This broke the FTL JIT build. It's no longer possible to build with LLVM checked out into a local directory after this change. I will roll this out unless you have a quick fix, since this prevents me from doing any work.
WebKit Commit Bot
Comment 7 2015-06-01 20:25:53 PDT
Re-opened since this is blocked by bug 145543
Mark Lam
Comment 8 2015-06-02 10:34:20 PDT
(In reply to comment #6) > This broke the FTL JIT build. It's no longer possible to build with LLVM > checked out into a local directory after this change. > > I will roll this out unless you have a quick fix, since this prevents me > from doing any work. As far as I can tell, this might be the issue: 1. Configurations/LLVMForJSC.xcconfig defines OTHER_LDFLAGS_LLVM = $(OTHER_LDFLAGS_LLVM_$(ENABLE_FTL_JIT)_$(CURRENT_ARCH)); 2. This in turn is used to map to OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT_x86_64 which provides the list of libs to link against. With the patch, the $ftlJIT case specifies ENABLE_FTL_JIT=ENABLE_FTL_JIT=1 to get the compiler option -DENABLE_FTL_JIT=1. I suspect that this throws a monkey wrench into configuration setup above. Once I change it to ENABLE_FTL_JIT=ENABLE_FTL_JIT, the issue is resolved. I’ll move forward with this as the fix since -DENABLE_FTL_JIT implicitly defines the symbol to 1 anyway i.e. it’s the same as -DENABLE_FTL_JIT=1.
Mark Lam
Comment 9 2015-06-02 10:44:27 PDT
Created attachment 254072 [details] patch for re-landing.
Mark Lam
Comment 10 2015-06-02 10:49:49 PDT
Patch re-landed in r185110: <http://trac.webkit.org/r185110>.
Note You need to log in before you can comment on or make changes to this bug.